From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out qemu-io prompt in 035
Date: Wed, 13 Nov 2013 15:02:27 +0100 [thread overview]
Message-ID: <20131113140227.GE2633@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <52837334.2090305@redhat.com>
Am 13.11.2013 um 13:40 hat Fam Zheng geschrieben:
> This change is manually copy&pasted into thunderbird. It has a super
> long line to kill `git send-email`, and is wrapped by email
> composer. So you need to pull to merge it.
'git send-email --no-validate' worked the last time I has something like
this.
> It is available as following branch, with one single commit:
>
> https://github.com/famz/qemu.git 035-filter-qemu-io
>
> Thanks,
>
> ---8<---
>
> Author: Fam Zheng <famz@redhat.com>
> Date: Wed Nov 13 20:19:05 2013 +0800
>
> qemu-iotests: Filter out qemu-io prompt in 035
>
> The order of "qemu-io> " and "wrote 512/512 bytes at offset XXX" output
> are indeterminic because of the parallism. Filter out the prompt will
> eliminate some variability.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
>
> diff --git a/tests/qemu-iotests/035 b/tests/qemu-iotests/035
> index ebe9b8c..95b0ce8 100755
> --- a/tests/qemu-iotests/035
> +++ b/tests/qemu-iotests/035
> @@ -60,7 +60,8 @@ function generate_requests() {
> }
>
> generate_requests | $QEMU_IO "$TEST_IMG" | _filter_qemu_io |\
> - sed -e 's/bytes at offset [0-9]*/bytes at offset XXX/g'
> + sed -e 's/bytes at offset [0-9]*/bytes at offset XXX/g' |\
> + sed -e 's/qemu-io> //g'
How about including the new filter in _filter_qemu_io instead?
Kevin
next prev parent reply other threads:[~2013-11-13 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 12:40 [Qemu-devel] [PATCH] qemu-iotests: Filter out qemu-io prompt in 035 Fam Zheng
2013-11-13 14:02 ` Kevin Wolf [this message]
2013-11-14 1:43 ` Fam Zheng
2013-11-14 12:26 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113140227.GE2633@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).