From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgt3R-0002sN-8m for qemu-devel@nongnu.org; Thu, 14 Nov 2013 04:17:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vgt3J-0006BX-VJ for qemu-devel@nongnu.org; Thu, 14 Nov 2013 04:17:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgt3J-0006BT-NH for qemu-devel@nongnu.org; Thu, 14 Nov 2013 04:17:29 -0500 Date: Thu, 14 Nov 2013 10:17:26 +0100 From: Kevin Wolf Message-ID: <20131114091726.GA9755@dhcp-200-207.str.redhat.com> References: <1384416928-3441-1-git-send-email-cyliu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384416928-3441-1-git-send-email-cyliu@suse.com> Subject: Re: [Qemu-devel] [PATCH] qemu-img: set nocow flag to new file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu Cc: qemu-devel@nongnu.org, stefanha@redhat.com Am 14.11.2013 um 09:15 hat Chunyan Liu geschrieben: > Set NOCOW flag to newly created images to solve performance issues on btrfs. > > Btrfs has terrible performance when hosting VM images, even more when the guest > in those VM are also using btrfs as file system. One way to mitigate this bad > performance is to turn off COW attributes on VM files (since having copy on > write for this kind of data is not useful). > > Signed-off-by: Chunyan Liu > --- > block/raw-posix.c | 6 ++++++ > block/vdi.c | 7 +++++++ > block/vmdk.c | 7 +++++++ > include/qemu-common.h | 9 +++++++++ > 4 files changed, 29 insertions(+), 0 deletions(-) > > diff --git a/block/raw-posix.c b/block/raw-posix.c > index f6d48bb..4a3e9d0 100644 > --- a/block/raw-posix.c > +++ b/block/raw-posix.c > @@ -1072,6 +1072,12 @@ static int raw_create(const char *filename, QEMUOptionParameter *options, > result = -errno; > error_setg_errno(errp, -result, "Could not create file"); > } else { > +#ifdef __linux__ > + /* set NOCOW flag to solve performance issue on fs like btrfs */ > + int attr; > + attr = FS_NOCOW_FL; > + ioctl(fd, FS_IOC_SETFLAGS, &attr); > +#endif ioctl() returning an error is ignored. This is probably okay because we're only talking about an optimisation here. Perhaps worth a word or two in the comment. However, while this ioctl is setting FS_NOCOW_FL, it is at the same time clearing all other flags. This doesn't look right. Kevin