From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgvZ7-00076I-OC for qemu-devel@nongnu.org; Thu, 14 Nov 2013 06:58:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgvZ1-00049l-OK for qemu-devel@nongnu.org; Thu, 14 Nov 2013 06:58:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgvZ1-00049b-HR for qemu-devel@nongnu.org; Thu, 14 Nov 2013 06:58:23 -0500 Date: Thu, 14 Nov 2013 14:01:16 +0200 From: "Michael S. Tsirkin" Message-ID: <20131114120116.GA4149@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] acpi: strip compiler info in built-in DSDT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Dave Frodin , Magnus Christensson , Gerd Hoffmann , Anthony Liguori , Kenji Kaneshige IASL stores it's revision in each table header it generates. That's not nice since guests will see a change each time they move between hypervisors. We generally fill our own info for tables, but we (and seabios) forgot to do this for the built-in DSDT. Signed-off-by: Michael S. Tsirkin --- Probably not important enough for 1.7. Queued for 1.8. hw/i386/acpi-build.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 486e705..8ae4f26 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -921,10 +921,16 @@ build_mcfg_q35(GArray *table_data, GArray *linker, AcpiMcfgInfo *info) static void build_dsdt(GArray *table_data, GArray *linker, AcpiMiscInfo *misc) { - void *dsdt; + AcpiTableHeader *dsdt; + assert(misc->dsdt_code && misc->dsdt_size); + dsdt = acpi_data_push(table_data, misc->dsdt_size); memcpy(dsdt, misc->dsdt_code, misc->dsdt_size); + + memset(dsdt, 0, sizeof *dsdt); + build_header(linker, table_data, dsdt, ACPI_DSDT_SIGNATURE, + misc->dsdt_size, 1); } /* Build final rsdt table */ -- MST