From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Vh9GT-0002dH-Do
	for qemu-devel@nongnu.org; Thu, 14 Nov 2013 21:36:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Vh9G4-00029n-TJ
	for qemu-devel@nongnu.org; Thu, 14 Nov 2013 21:36:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40358)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1Vh9G4-00029e-KR
	for qemu-devel@nongnu.org; Thu, 14 Nov 2013 21:35:44 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAF2Zggi011159
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 14 Nov 2013 21:35:42 -0500
Date: Thu, 14 Nov 2013 21:29:10 -0500
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20131114212910.0fbb9d9c@redhat.com>
In-Reply-To: <1384439646-19703-1-git-send-email-stefanha@redhat.com>
References: <1384439646-19703-1-git-send-email-stefanha@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: filter QEMU monitor \r\n
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

On Thu, 14 Nov 2013 15:34:06 +0100
Stefan Hajnoczi <stefanha@redhat.com> wrote:

> SMTP does not preserve newlines.  This is normally not a problem if the
> email body uses DOS or UNIX newlines consistently.  In 051.out we mix
> UNIX newlines with DOS newlines (since QEMU monitor output uses \r\n).
> 
> This patch filters the QEMU monitor output so the golden master file
> uses UNIX newlines exclusively.
> 
> The result is that patches touching 051.out will apply cleanly without
> mangling newlines after this commit.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> If you have trouble applying this patch, you can use by git repo:
>   git://github.com/stefanha/qemu.git fix-qemu-io-cr
> 
> Luiz: CCed you just because I was surprised monitor.c uses \r\n.  Perhaps this
> is because terminal or telnet emulation is somehow mixed into the core
> monitor.c code?

Yes, it's telnet support (we allow a telnet client to connect to the
monitor).