From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices
Date: Fri, 15 Nov 2013 09:18:11 +0100 [thread overview]
Message-ID: <20131115081811.GB12545@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <5284D90D.6040708@redhat.com>
On Thu, Nov 14, 2013 at 03:07:09PM +0100, Paolo Bonzini wrote:
> Il 14/11/2013 14:41, Stefan Hajnoczi ha scritto:
> But such a no-op streaming is valid, just like it is valid to
> enable copy-on-read without a backing file. Think of a system that
> starts streaming a disk as soon as the VM starts, because *if* there's a
> backing file it knows it is just a template on a remote/slow filesytem.
> It's easier for such a system to invoke the command even if there's no
> backing file.
Since making it an error breaks the API now, let's take this patch and
move on.
I still think it could help users that are issuing the command
incorrectly, but there's not much we can do about that now.
Stefan
prev parent reply other threads:[~2013-11-15 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 19:37 [Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices Max Reitz
2013-11-14 3:00 ` Wenchao Xia
2013-11-14 12:15 ` Kevin Wolf
2013-11-14 13:41 ` Stefan Hajnoczi
2013-11-14 14:00 ` Eric Blake
2013-11-14 14:07 ` Paolo Bonzini
2013-11-15 8:18 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131115081811.GB12545@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).