qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Zhanghaoyu (A)" <haoyu.zhang@huawei.com>
Cc: "Huangweidong (C)" <weidong.huang@huawei.com>,
	"quintela@redhat.com" <quintela@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Michal Privoznik <mprivozn@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"paolo.bonzini@gmail.com" <paolo.bonzini@gmail.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Xiahai <xiahai@huawei.com>, Linqiangmin <linqiangmin@huawei.com>,
	Zanghongyong <zanghongyong@huawei.com>,
	Luonengjun <luonengjun@huawei.com>,
	"Huangpeng (Peter)" <peter.huangpeng@huawei.com>
Subject: Re: [Qemu-devel] [migration] questions about removing the old block-migration code
Date: Fri, 15 Nov 2013 16:33:46 +0100	[thread overview]
Message-ID: <20131115153346.GB26518@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <D3E216785288A145B7BC975F83A2ED1043EF3BE3@szxeml556-mbx.china.huawei.com>

On Fri, Nov 08, 2013 at 01:17:17AM +0000, Zhanghaoyu (A) wrote:
> >> I read below words on the report of <KVM Live Migration: Weather 
> >> forecast (May 29, 2013)>, We were going to remove the old 
> >> block-migration code Then people fixed it
> >> Good: it works now
> >> Bad: We have to maintain both
> >> It uses the same port than migration
> >> You need to migrate all/none of block devices
> >> 
> >> The old block-migration code said above is that in block-migration.c?
> >
> >Yes.
> >
> >> What are the reasons of removing the old block-migration code? Buggy implementation? Or need to migrate all/none of block devices?
> >
> >Buggy and tightly coupled with the live migration code, making it hard to modify either area independently.
> 
> Thanks a lot for explaining.
> Till now, we still use the old block-migration code in our virtualization solution.
> Could you detail the bugs that the old block-migration code have?

Please use git log block-migration.c to see bugs that have been fixed.

The basic problem is that block-migration.c hasn't been actively
maintained or used much.  My impression is that the newer block
migration approach using drive-mirror now has more developer and testing
focus (see libvirt if you're curious how drive-mirror can be
orchestrated).

Stefan

      reply	other threads:[~2013-11-15 15:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-03  4:01 [Qemu-devel] [migration] questions about removing the old block-migration code Zhanghaoyu (A)
2013-11-05 13:34 ` Stefan Hajnoczi
2013-11-08  1:17   ` Zhanghaoyu (A)
2013-11-15 15:33     ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131115153346.GB26518@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=haoyu.zhang@huawei.com \
    --cc=linqiangmin@huawei.com \
    --cc=luonengjun@huawei.com \
    --cc=mprivozn@redhat.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=paolo.bonzini@gmail.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=weidong.huang@huawei.com \
    --cc=xiahai@huawei.com \
    --cc=zanghongyong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).