From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41295)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ViLQj-000367-Tb
	for qemu-devel@nongnu.org; Mon, 18 Nov 2013 04:47:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ViLQd-0006vj-ON
	for qemu-devel@nongnu.org; Mon, 18 Nov 2013 04:47:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60866)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ViLQd-0006uw-GZ
	for qemu-devel@nongnu.org; Mon, 18 Nov 2013 04:47:35 -0500
Date: Mon, 18 Nov 2013 11:50:43 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131118095043.GA3470@redhat.com>
References: <1384764380-16832-1-git-send-email-zwu.kernel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1384764380-16832-1-git-send-email-zwu.kernel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] net,
	virtio_net: replace the magic value
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: netdev@vger.kernel.org, rusty@rustcorp.com.au, Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, qemu-devel@nongnu.org, linux-kernel@vger.kernel.org

On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> 
> It is more appropriate to use # of queue pairs currently used by
> the driver instead of a magic value.
> 
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>

I don't mind, but driver should be submitted separately
from qemu patches. As it is only patch 4/4 made it to netdev.

> ---
>  drivers/net/virtio_net.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index cdc7c90..e0cb2d1 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1619,8 +1619,8 @@ static int virtnet_probe(struct virtio_device *vdev)
>  	if (err)
>  		goto free_stats;
>  
> -	netif_set_real_num_tx_queues(dev, 1);
> -	netif_set_real_num_rx_queues(dev, 1);
> +	netif_set_real_num_tx_queues(dev, vi->curr_queue_pairs);
> +	netif_set_real_num_rx_queues(dev, vi->curr_queue_pairs);
>  
>  	err = register_netdev(dev);
>  	if (err) {
> -- 
> 1.7.6.5
>