From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] doc: fix hardcode helper path
Date: Mon, 18 Nov 2013 13:38:10 +0200 [thread overview]
Message-ID: <20131118113810.GA5393@redhat.com> (raw)
In-Reply-To: <1382474968-2486-1-git-send-email-akong@redhat.com>
On Wed, Oct 23, 2013 at 04:49:28AM +0800, Amos Kong wrote:
> The install directory of qemu-bridge-helper is configurabled,
> but we used a fixed path in document.
>
> DEFAULT_BRIDGE_HELPER macro isn't available in texi mode,
> we always use "/path/to/" prefix for dynamic path (eg:
> /path/to/image, /path/to/linux, etc).
>
> Signed-off-by: Amos Kong <akong@redhat.com>
Applied, thanks.
> ---
> qemu-options.hx | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 5dc8b75..8b94264 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1605,7 +1605,7 @@ to disable script execution.
>
> If running QEMU as an unprivileged user, use the network helper
> @var{helper} to configure the TAP interface. The default network
> -helper executable is @file{/usr/local/libexec/qemu-bridge-helper}.
> +helper executable is @file{/path/to/qemu-bridge-helper}.
>
> @option{fd}=@var{h} can be used to specify the handle of an already
> opened host TAP interface.
> @@ -1629,7 +1629,7 @@ qemu-system-i386 linux.img \
> #launch a QEMU instance with the default network helper to
> #connect a TAP device to bridge br0
> qemu-system-i386 linux.img \
> - -net nic -net tap,"helper=/usr/local/libexec/qemu-bridge-helper"
> + -net nic -net tap,"helper=/path/to/qemu-bridge-helper"
> @end example
>
> @item -netdev bridge,id=@var{id}[,br=@var{bridge}][,helper=@var{helper}]
> @@ -1638,7 +1638,7 @@ Connect a host TAP network interface to a host bridge device.
>
> Use the network helper @var{helper} to configure the TAP interface and
> attach it to the bridge. The default network helper executable is
> -@file{/usr/local/libexec/qemu-bridge-helper} and the default bridge
> +@file{/path/to/qemu-bridge-helper} and the default bridge
> device is @file{br0}.
>
> Examples:
> --
> 1.8.3.1
>
prev parent reply other threads:[~2013-11-18 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 20:49 [Qemu-devel] [PATCH] doc: fix hardcode helper path Amos Kong
2013-11-05 12:14 ` Stefan Hajnoczi
2013-11-18 11:38 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118113810.GA5393@redhat.com \
--to=mst@redhat.com \
--cc=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).