From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37450)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ViOpu-0000E6-8J
	for qemu-devel@nongnu.org; Mon, 18 Nov 2013 08:26:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ViOpl-0000PL-D4
	for qemu-devel@nongnu.org; Mon, 18 Nov 2013 08:25:54 -0500
Received: from mail-bk0-x230.google.com ([2a00:1450:4008:c01::230]:34374)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ViOpl-0000P2-1q
	for qemu-devel@nongnu.org; Mon, 18 Nov 2013 08:25:45 -0500
Received: by mail-bk0-f48.google.com with SMTP id v10so1990245bkz.7
	for <qemu-devel@nongnu.org>; Mon, 18 Nov 2013 05:25:43 -0800 (PST)
Date: Mon, 18 Nov 2013 14:25:40 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131118132540.GA31173@stefanha-thinkpad.hitronhub.home>
References: <1384762812-22581-1-git-send-email-akong@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1384762812-22581-1-git-send-email-akong@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] net: move rxfilter_notify() to net.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: vyasevic@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, Nov 18, 2013 at 04:20:12PM +0800, Amos Kong wrote:
> @@ -967,6 +968,27 @@ void print_net_client(Monitor *mon, NetClientState *nc)
>                     nc->info_str);
>  }
>  
> +void rxfilter_notify(NetClientState *nc, Object *obj)
> +{
> +    QObject *event_data;
> +    gchar *path = object_get_canonical_path(obj);
> +
> +    if (nc->rxfilter_notify_enabled) {
> +        if (nc->name) {
> +            event_data = qobject_from_jsonf("{ 'name': %s, 'path': %s }",
> +                                            nc->name, path);
> +        } else {
> +            event_data = qobject_from_jsonf("{ 'path': %s }", path);
> +        }
> +        monitor_protocol_event(QEVENT_NIC_RX_FILTER_CHANGED, event_data);
> +        qobject_decref(event_data);
> +
> +        /* disable event notification to avoid events flooding */
> +        nc->rxfilter_notify_enabled = 0;

Only hw/net/virtio-net.c uses nc->rxfilter_notify_enabled.  This
function isn't reusable in its current form so I'm left wondering what
the point of this patch is?

If you have patches that invoke rxfilter_notify() from other NICs then
please submit them together in a series.

Otherwise, let's not move things around just for the sake of it,
especially when the refactoring is not done correctly.

Stefan