From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViQbD-0001xu-IQ for qemu-devel@nongnu.org; Mon, 18 Nov 2013 10:18:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViQb7-00063M-EI for qemu-devel@nongnu.org; Mon, 18 Nov 2013 10:18:51 -0500 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:36750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViQb7-00063B-6U for qemu-devel@nongnu.org; Mon, 18 Nov 2013 10:18:45 -0500 Received: by mail-wi0-f175.google.com with SMTP id hm11so3974558wib.8 for ; Mon, 18 Nov 2013 07:18:43 -0800 (PST) Date: Mon, 18 Nov 2013 16:18:41 +0100 From: Stefan Hajnoczi Message-ID: <20131118151841.GD4083@stefanha-thinkpad.redhat.com> References: <1384442051-2925-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384442051-2925-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-1.7] tests: add missing -display none to qtests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Anthony Liguori On Thu, Nov 14, 2013 at 04:14:11PM +0100, Stefan Hajnoczi wrote: > Commit 7ceeedd016facf8d58e14a0d1417fa7225d71072 ("blockdev-test: add > test case for drive_add duplicate IDs") and commit > 43cd209803d6cffb1e1a028c9ff2fd0ff4fce954 ("qdev-monitor-test: add > device_add leak test cases") added qtest tests without specifying > -display none. > > As a result, "make check" now tries to use graphics (GTK or SDL). Since > graphics are not used by the test and inappropriate for headless "make > check" runs, add the missing -display none. > > This fixes "make check" in the QEMU buildbot. > > Signed-off-by: Stefan Hajnoczi > --- > tests/blockdev-test.c | 2 +- > tests/qdev-monitor-test.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan