From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: vyasevic@redhat.com, Amos Kong <akong@redhat.com>,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify()
Date: Mon, 18 Nov 2013 17:20:41 +0200 [thread overview]
Message-ID: <20131118152041.GD25899@redhat.com> (raw)
In-Reply-To: <20131118151408.GB4083@stefanha-thinkpad.redhat.com>
On Mon, Nov 18, 2013 at 04:14:08PM +0100, Stefan Hajnoczi wrote:
> On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote:
> > object_get_canonical_path() returns a gchar*, it should be freeed by the
> > caller.
> >
> > Signed-off-by: Amos Kong <akong@redhat.com>
> > ---
> > hw/net/virtio-net.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Thanks, applied to my net tree (will send pull request for QEMU 1.7):
> https://github.com/stefanha/qemu/commits/net
>
> Stefan
I'd prefer it for my comment to be addressed first ...
next prev parent reply other threads:[~2013-11-18 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 13:47 [Qemu-devel] [PATCH] virtio-net: fix the memory leak in rxfilter_notify() Amos Kong
2013-11-18 13:54 ` Vlad Yasevich
2013-11-18 13:55 ` Michael S. Tsirkin
2013-11-18 15:14 ` Stefan Hajnoczi
2013-11-18 15:20 ` Michael S. Tsirkin [this message]
2013-11-19 8:44 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118152041.GD25899@redhat.com \
--to=mst@redhat.com \
--cc=akong@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).