From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Add "-c <cache-mode>" to check
Date: Mon, 18 Nov 2013 16:40:39 +0100 [thread overview]
Message-ID: <20131118154039.GD5166@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <20131118153251.GF4083@stefanha-thinkpad.redhat.com>
Am 18.11.2013 um 16:32 hat Stefan Hajnoczi geschrieben:
> On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote:
> > The default cache mode for drive options is changed to writethrough, and
> > overridable with "./check -c <mode>".
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > tests/qemu-iotests/common | 13 ++++++++++++-
> > tests/qemu-iotests/iotests.py | 3 ++-
> > 2 files changed, 14 insertions(+), 2 deletions(-)
>
> BTW, I looked back at Kevin's reply to your earlier patch and saw he
> suggested making the default "writethrough".
>
> Kevin: Any reason not to use "writeback" by default?
I'm not opposed to changing the default in a second step. It's just that
writethrough is the default today and tests not respecting this are
buggy. So the incremental fix is to make them obey the global setting,
and then that setting can be tweaked in a second step.
Kevin
next prev parent reply other threads:[~2013-11-18 15:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 2:24 [Qemu-devel] [PATCH] qemu-iotests: Add "-c <cache-mode>" to check Fam Zheng
2013-11-14 3:26 ` Wenchao Xia
2013-11-18 15:29 ` Stefan Hajnoczi
2013-11-18 15:38 ` Kevin Wolf
2013-11-19 6:46 ` Fam Zheng
2013-11-18 15:32 ` Stefan Hajnoczi
2013-11-18 15:40 ` Kevin Wolf [this message]
2013-11-19 8:39 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118154039.GD5166@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).