From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37344)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ViXhi-00077U-R3
	for qemu-devel@nongnu.org; Mon, 18 Nov 2013 17:54:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ViXhc-00049B-Jk
	for qemu-devel@nongnu.org; Mon, 18 Nov 2013 17:54:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:8577)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ViXhc-00048z-B1
	for qemu-devel@nongnu.org; Mon, 18 Nov 2013 17:53:56 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAIMrsnn024688
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 18 Nov 2013 17:53:55 -0500
Date: Tue, 19 Nov 2013 00:57:08 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131118225708.GA1311@redhat.com>
References: <528A7D64.4020908@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <528A7D64.4020908@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [for-1.7] hw/i386/acpi-build.c vs glib-2.12
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Tue, Nov 19, 2013 at 06:49:40AM +1000, Richard Henderson wrote:
> hw/i386/acpi-build.c:294:5: error: implicit declaration of function
> =E2=80=98g_string_vprintf=E2=80=99 [-Werror=3Dimplicit-function-declara=
tion]
>      g_string_vprintf(s, format, args);
>=20
> Introduced in 2.14.
>=20
>=20
> hw/i386/acpi-build.c:427:5: error: implicit declaration of function
> =E2=80=98g_array_get_element_size=E2=80=99 [-Werror=3Dimplicit-function=
-declaration]
>      return table->len * g_array_get_element_size(table);
>=20
> Introduced in 2.22.
>=20
>=20
> Our (self-)documented minimums are
>=20
> if test "$mingw32" =3D yes; then
>     # g_poll is required in order to integrate with the glib main loop.
>     glib_req_ver=3D2.20
> else
>     glib_req_ver=3D2.12
> fi
>=20
>=20
> Within unix variants at least, vs(n)printf is likely to be much more po=
rtable
> than the glib function.

Hmm. The nice thing with the glib variant is that it allocated memory.
Our specific use is actually 4 bytes so yes, we can make do without.

>  I suspect MinGW has it as well, though I've not checked.
>=20
> As for g_array_get_element_size, aren't all of your tables element size=
 1?
> That's all I can see from acpi_build_tables_init, though I admit to not=
 digging
> deeper.
>=20
>=20
>=20
> r~

There's one with size > 1, though that's not hard to change.