From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47901)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Vigql-0008V1-0x
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:40:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Vigqf-0003GZ-I5
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:39:58 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60447)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Vigqf-0003GF-9q
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:39:53 -0500
Date: Tue, 19 Nov 2013 09:39:48 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20131119083948.GB26888@stefanha-thinkpad.redhat.com>
References: <1384395844-21926-1-git-send-email-famz@redhat.com>
	<20131118153251.GF4083@stefanha-thinkpad.redhat.com>
	<20131118154039.GD5166@dhcp-200-207.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131118154039.GD5166@dhcp-200-207.str.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Add "-c <cache-mode>" to
	check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org

On Mon, Nov 18, 2013 at 04:40:39PM +0100, Kevin Wolf wrote:
> Am 18.11.2013 um 16:32 hat Stefan Hajnoczi geschrieben:
> > On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote:
> > > The default cache mode for drive options is changed to writethrough, and
> > > overridable with "./check -c <mode>".
> > > 
> > > Signed-off-by: Fam Zheng <famz@redhat.com>
> > > ---
> > >  tests/qemu-iotests/common     | 13 ++++++++++++-
> > >  tests/qemu-iotests/iotests.py |  3 ++-
> > >  2 files changed, 14 insertions(+), 2 deletions(-)
> > 
> > BTW, I looked back at Kevin's reply to your earlier patch and saw he
> > suggested making the default "writethrough".
> > 
> > Kevin: Any reason not to use "writeback" by default?
> 
> I'm not opposed to changing the default in a second step. It's just that
> writethrough is the default today and tests not respecting this are
> buggy. So the incremental fix is to make them obey the global setting,
> and then that setting can be tweaked in a second step.

Makes sense.

Stefan