From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49098)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1VigvX-0002IT-Hr
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:45:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1VigvS-00058z-ON
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:44:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:26724)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1VigvS-00058t-Fz
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:44:50 -0500
Date: Tue, 19 Nov 2013 09:44:47 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20131119084447.GC26888@stefanha-thinkpad.redhat.com>
References: <1384782445-26527-1-git-send-email-akong@redhat.com>
	<20131118151408.GB4083@stefanha-thinkpad.redhat.com>
	<20131118152041.GD25899@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131118152041.GD25899@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-net: fix the memory leak in
 rxfilter_notify()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: vyasevic@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>, Amos Kong <akong@redhat.com>, qemu-devel@nongnu.org

On Mon, Nov 18, 2013 at 05:20:41PM +0200, Michael S. Tsirkin wrote:
> On Mon, Nov 18, 2013 at 04:14:08PM +0100, Stefan Hajnoczi wrote:
> > On Mon, Nov 18, 2013 at 09:47:25PM +0800, Amos Kong wrote:
> > > object_get_canonical_path() returns a gchar*, it should be freeed by the
> > > caller.
> > > 
> > > Signed-off-by: Amos Kong <akong@redhat.com>
> > > ---
> > >  hw/net/virtio-net.c | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > Thanks, applied to my net tree (will send pull request for QEMU 1.7):
> > https://github.com/stefanha/qemu/commits/net
> > 
> > Stefan
> 
> I'd prefer it for my comment to be addressed first ...

I folded your suggestion into the commit.

Stefan