From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vigxf-0003Gs-2L for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:47:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VigxX-00061W-GZ for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:47:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VigxX-00061J-8O for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:46:59 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAJ8kwL3010036 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Nov 2013 03:46:58 -0500 Date: Tue, 19 Nov 2013 09:46:56 +0100 From: Stefan Hajnoczi Message-ID: <20131119084656.GA27265@stefanha-thinkpad.redhat.com> References: <1384788737-6233-1-git-send-email-akong@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384788737-6233-1-git-send-email-akong@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] virtio-net: fix the memory leak in rxfilter_notify() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: vyasevic@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On Mon, Nov 18, 2013 at 11:32:17PM +0800, Amos Kong wrote: > object_get_canonical_path() returns a gchar*, it should be freeed by the > caller. > > Signed-off-by: Amos Kong > --- > v2: put gchar *path inside rxfilter_notify_enabled block > --- > hw/net/virtio-net.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan