From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52344)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Vih85-0000mF-UN
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:57:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Vih81-0001BQ-1i
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:57:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39634)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1Vih80-0001BC-Ot
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 03:57:48 -0500
Date: Tue, 19 Nov 2013 09:57:44 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20131119085744.GD27265@stefanha-thinkpad.redhat.com>
References: <1384792594-21102-1-git-send-email-afaerber@suse.de>
	<20131118164828.GA12155@stefanha-thinkpad.redhat.com>
	<528A4649.2060709@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <528A4649.2060709@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qtest: Use -display none by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: kwolf@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com

On Mon, Nov 18, 2013 at 05:54:33PM +0100, Andreas F=E4rber wrote:
> Am 18.11.2013 17:48, schrieb Stefan Hajnoczi:
> > On Mon, Nov 18, 2013 at 05:36:34PM +0100, Andreas F=E4rber wrote:
> >> This avoids each test needing to add it to suppress windows popping =
up.
> >>
> >> Signed-off-by: Andreas F=E4rber <afaerber@suse.de>
> >> ---
> >>  tests/boot-order-test.c | 2 +-
> >>  tests/endianness-test.c | 6 +++---
> >>  tests/fw_cfg-test.c     | 3 +--
> >>  tests/hd-geo-test.c     | 2 +-
> >>  tests/i440fx-test.c     | 2 +-
> >>  tests/libqtest.c        | 1 +
> >>  tests/m48t59-test.c     | 2 +-
> >>  tests/qom-test.c        | 2 +-
> >>  tests/rtc-test.c        | 2 +-
> >>  tests/tmp105-test.c     | 2 +-
> >>  10 files changed, 12 insertions(+), 12 deletions(-)
> >=20
> > I avoided making -display none common because tests may wish to have =
a
> > display.  But at the moment no test needs a display so I guess this i=
s
> > fine.
>=20
> I was under the assumption that -display none -display sdl would work
> just like mst's overriding the default -machine accel=3Dqtest with
> -machine accel=3Dtcg?

Good point.  I checked the code and it works.

Let's take your patch since it also prevents future problems.

Stefan