From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44317)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ViiR2-000275-OL
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 05:21:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ViiQx-0002Oh-DE
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 05:21:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:12987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ViiQx-0002OX-68
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 05:21:27 -0500
Date: Tue, 19 Nov 2013 11:21:22 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131119102122.GB4040@dhcp-200-207.str.redhat.com>
References: <1384843537-14112-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1384843537-14112-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Add cache mode option to
	qemu-iotests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>

Am 19.11.2013 um 07:45 hat Fam Zheng geschrieben:
> The first patch adds "-c <mode>" option to ./check and convert "-nocache" to an
> alias to "-c none". The mode is used in qemu-io.
> 
> The second patch modifies iotests.py to use the cache mode option in qemu drive
> command line.

Okay, I gave it some testing, too, and it looks like we need some
additional changes. There are some test cases that use:

_unsupported_qemu_io_options --nocache

Which obviously doesn't work any more. We need to replace it by a check
against $CACHEMODE (or, perhaps preferably, even override it
automatically, so that test cases aren't left out just because of the
cache mode)

Test case 026 uses the option of having a 026.out.nocache, which differs
from the normal output. I suspect the correct differentiation is here
between writethrough and writeback modes. And of course, grepping for
'--nocache' to detect the condition doesn't work any more.

Kevin