From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vijzz-0004fB-7N for qemu-devel@nongnu.org; Tue, 19 Nov 2013 07:01:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vijzs-0001la-Md for qemu-devel@nongnu.org; Tue, 19 Nov 2013 07:01:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vijzs-0001lU-DL for qemu-devel@nongnu.org; Tue, 19 Nov 2013 07:01:36 -0500 Date: Tue, 19 Nov 2013 14:04:45 +0200 From: "Michael S. Tsirkin" Message-ID: <20131119120445.GA11075@redhat.com> References: <1383820884-29596-1-git-send-email-marcel.a@redhat.com> <1383820884-29596-8-git-send-email-marcel.a@redhat.com> <528B4F2A.2030904@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <528B4F2A.2030904@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-1.7 v2 7/8] pc: s/INT64_MAX/UINT64_MAX/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, ehabkost@redhat.com, Marcel Apfelbaum , jan.kiszka@siemens.com, agraf@suse.de, qemu-devel@nongnu.org, aliguori@amazon.com, lcapitulino@redhat.com, afaerber@suse.de On Tue, Nov 19, 2013 at 12:44:42PM +0100, Paolo Bonzini wrote: > Il 07/11/2013 11:41, Marcel Apfelbaum ha scritto: > > From: Paolo Bonzini > > > > It doesn't make sense for a region to be INT64_MAX in size: > > memory core uses UINT64_MAX as a special value meaning > > "all 64 bit" this is what was meant here. > > > > While this should never affect the PC system which at the moment always > > has < 63 bit size, this makes us hit all kind of corner case bugs with > > sub-pages, so users are probably better off if we just use UINT64_MAX > > instead. > > > > Reported-by: Luiz Capitulino > > Tested-by: Luiz Capitulino > > Reviewed-by: Michael S. Tsirkin > > Signed-off-by: Michael S. Tsirkin > > Michael, is this patch (and 8/8: spapr_pci: s/INT64_MAX/UINT64_MAX/) > queued for 1.7 and/or 1.8? > > Paolo I queued this for 1.8 - I don't think it fixes any known specific bugs. You can see my queue at git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git pci > > --- > > hw/i386/pc_piix.c | 2 +- > > hw/i386/pc_q35.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > > index 4fdb7b6..8e8d354 100644 > > --- a/hw/i386/pc_piix.c > > +++ b/hw/i386/pc_piix.c > > @@ -115,7 +115,7 @@ static void pc_init1(QEMUMachineInitArgs *args, > > > > if (pci_enabled) { > > pci_memory = g_new(MemoryRegion, 1); > > - memory_region_init(pci_memory, NULL, "pci", INT64_MAX); > > + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); > > rom_memory = pci_memory; > > } else { > > pci_memory = NULL; > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > > index 4c191d3..ca44e05 100644 > > --- a/hw/i386/pc_q35.c > > +++ b/hw/i386/pc_q35.c > > @@ -102,7 +102,7 @@ static void pc_q35_init(QEMUMachineInitArgs *args) > > /* pci enabled */ > > if (pci_enabled) { > > pci_memory = g_new(MemoryRegion, 1); > > - memory_region_init(pci_memory, NULL, "pci", INT64_MAX); > > + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); > > rom_memory = pci_memory; > > } else { > > pci_memory = NULL; > >