From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjOQ9-0007Dk-E1 for qemu-devel@nongnu.org; Thu, 21 Nov 2013 02:11:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjOQ3-0008P2-Et for qemu-devel@nongnu.org; Thu, 21 Nov 2013 02:11:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjOQ3-0008Ow-6l for qemu-devel@nongnu.org; Thu, 21 Nov 2013 02:11:19 -0500 Date: Thu, 21 Nov 2013 09:14:18 +0200 From: "Michael S. Tsirkin" Message-ID: <20131121071418.GB19703@redhat.com> References: <1385001528-12003-1-git-send-email-imammedo@redhat.com> <1385001528-12003-17-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1385001528-12003-17-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, stefanha@redhat.com, stefanb@linux.vnet.ibm.com, qemu-devel@nongnu.org, chegu_vinod@hp.com, marcel.a@redhat.com, mjt@tls.msk.ru, mdroth@linux.vnet.ibm.com, armbru@redhat.com, vasilis.liaskovitis@profitbricks.com, quintela@redhat.com, kraxel@redhat.com, aliguori@amazon.com, hutao@cn.fujitsu.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote: > it fixes IRQ storm since guest isn't able to lower SCI IRQ > after it has been handled when it clears GPE event. > > Signed-off-by: Igor Mammedov The storm is only on memory hotplug right? But memory hotplug support is only added by next patch. Maybe just smash with that one? > --- > hw/acpi/ich9.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c > index e59688b..fb88162 100644 > --- a/hw/acpi/ich9.c > +++ b/hw/acpi/ich9.c > @@ -61,6 +61,7 @@ static void ich9_gpe_writeb(void *opaque, hwaddr addr, uint64_t val, > { > ICH9LPCPMRegs *pm = opaque; > acpi_gpe_ioport_writeb(&pm->acpi_regs, addr, val); > + acpi_update_sci(&pm->acpi_regs, pm->irq, ACPI_MEMORY_HOTPLUG_STATUS); > } > > static const MemoryRegionOps ich9_gpe_ops = { > -- > 1.7.1