Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

[Stefan Hajnoczi <stefanha@gmail.com>]

On Wed, Nov 20, 2013 at 05:40:15PM +0000, Tomoki Sekiyama wrote:
> On 11/20/13 4:16 , "Stefan Hajnoczi" <stefanha@gmail.com> wrote:
> >Sorry, I forgot to CC qemu-devel on this:
> >
> >On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi <stefanha@gmail.com>
> >wrote:
> >> Hi,
> >> The mingw32 build is failing as follows:
> >>
> >> In file included from qga/vss-win32.c:17:
> >> ./qga/vss-win32/requester.h:31: error: expected '=', ',', ';', 'asm'
> >> or '__attribute__' before 'requester_init'
> >> ./qga/vss-win32/requester.h:32: error: expected '=', ',', ';', 'asm'
> >> or '__attribute__' before 'requester_deinit'
> >>
> >> http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/783
> >>
> >> It's important that we keep the QEMU buildbot working so that compile
> >> errors and test failures are caught before release.  The buildbot is
> >> currently in bad shape (lots of failures), so I am sending out emails
> >> requesting help.
> >>
> >> I'm emailing you since you are familiar with the code and might be
> >> able to fix this issue.  Do you have time to investigate?
> >>
> >> If not, please CC folks who can help.
> >>
> >> Thanks,
> >> Stefan
> 
> Thanks for letting me know this.
> 
> I'm investigating the issue, but it looks already fixed in the code in
> the upstream git tree, by commit ba1c293109:
>     "qga: Fix compilation for old version of MinGW"
> 
> Could you try this fix?

Excellent, thanks!  The latest buildbot has compiled successfully:
http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/784

It's now hitting a make check failure unrelated to VSS.

Thanks,
Stefan