From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42887)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VjSKy-0002Tk-F4
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 06:22:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VjSKs-0007v8-4r
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 06:22:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50745)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VjSKr-0007ut-TC
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 06:22:14 -0500
Date: Thu, 21 Nov 2013 13:25:26 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131121112526.GA31128@redhat.com>
References: <528A7D64.4020908@redhat.com> <20131121091506.GA22462@redhat.com>
	<CAFEAcA9wLt6pWgFaMdfLkR3=QA6_ifrL4_4MJG0qvDtuV8-Hiw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA9wLt6pWgFaMdfLkR3=QA6_ifrL4_4MJG0qvDtuV8-Hiw@mail.gmail.com>
Subject: Re: [Qemu-devel] [for-1.7] hw/i386/acpi-build.c vs glib-2.12
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Richard Henderson <rth@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Thu, Nov 21, 2013 at 10:09:58AM +0000, Peter Maydell wrote:
> On 21 November 2013 09:15, Michael S. Tsirkin <mst@redhat.com> wrote:
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index 486e705..97e0fba 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -287,14 +287,17 @@ static inline void build_append_array(GArray *array, GArray *val)
> >
> >  static void build_append_nameseg(GArray *array, const char *format, ...)
> >  {
> > -    GString *s = g_string_new("");
> > +    /* It would be nicer to use g_string_vprintf but it's only there in 2.22 */
> > +    char s[] = "XXXX";
> > +    int len;
> >      va_list args;
> >
> >      va_start(args, format);
> >      g_string_vprintf(s, format, args);
> > +    len = vsnprintf(s, sizeof s, format, args);
> >      va_end(args);
> 
> ...this patch doesn't seem to have removed the g_string_vprintf
> call?
> 
> thanks
> -- PMM

yes and I found more issues.
Pls don't test yet I'll post v2.