From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59963)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <janne@jannau.net>) id 1VjTTW-0005hj-Q3
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:35:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <janne@jannau.net>) id 1VjTTR-0004pH-TA
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:35:14 -0500
Received: from sianko.jannau.net ([83.133.106.15]:52327)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <janne@jannau.net>) id 1VjTTR-0004oX-NT
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:35:09 -0500
Date: Thu, 21 Nov 2013 13:34:00 +0100
From: Janne Grunau <j@jannau.net>
Message-ID: <20131121123400.GD12412@sianko.jannau.net>
References: <1380242934-20953-1-git-send-email-agraf@suse.de>
	<1380242934-20953-51-git-send-email-agraf@suse.de>
	<20131119204153.GC12412@sianko.jannau.net>
	<alpine.LNX.2.00.1311201544540.11100@wotan.suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LNX.2.00.1311201544540.11100@wotan.suse.de>
Subject: Re: [Qemu-devel] [PATCH 50/60] AArch64: Add
 "Floating-point<->fixed-point
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Matz <matz@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, C Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Laurent Desnogues <laurent.desnogues@gmail.com>, Christoffer Dall <christoffer.dall@linaro.org>, Richard Henderson <rth@twiddle.net>

On 2013-11-20 15:47:18 +0100, Michael Matz wrote:
> Hi,
> 
> On Tue, 19 Nov 2013, Janne Grunau wrote:
> 
> > > +static void handle_fpfpconv(DisasContext *s, uint32_t insn)
> > > +{
> > > +    int opcode = get_bits(insn, 16, 3);
> > > +    int rmode = get_bits(insn, 20, 2);
> > 
> > rmode is at 19
> > 
> > > +    case 0x1: /* [S|U]CVTF (scalar->float) */
> > 
> > and it's case 0x0: for [S|U]CVTF
> 
> Both were fixed after Alex' series with 0dd22d0c:
> https://github.com/susematz/qemu/commit/0dd22d0c5cd1dcdccd5df953f1981d461d3054e5

wouldn't make sense to squash that fix into this patch? I'm not used to
the qemu development model but committing patches with already fixed
issues looks strange to me. Unless it's planned to fold the entire patch
series into one large commit.

Janne