From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33753)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VjTbr-0001ag-1K
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:43:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VjTbk-00075P-Ez
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:43:50 -0500
Received: from mail-we0-x236.google.com ([2a00:1450:400c:c03::236]:37235)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VjTbk-00075J-90
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 07:43:44 -0500
Received: by mail-we0-f182.google.com with SMTP id q59so8462356wes.41
	for <qemu-devel@nongnu.org>; Thu, 21 Nov 2013 04:43:43 -0800 (PST)
Date: Thu, 21 Nov 2013 13:43:40 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131121124340.GC7466@stefanha-thinkpad.redhat.com>
References: <1384933457-26953-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1384933457-26953-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/6] Add cache mode option to
 qemu-iotests, and change default mode to "writeback"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, WenchaoXia <xiawenc@linux.vnet.ibm.com>

On Wed, Nov 20, 2013 at 03:44:11PM +0800, Fam Zheng wrote:
> This series adds cache mode option in the iotests framework. Test cases are
> updated to make use of cache mode and mask supported modes.
> 
> v3: Change _unsupported_qemu_io_options to _supported_cache_modes.
>     Change default mode to "writeback".
>     Clean up some whitespaces in the end of series.
>     Fix "026.out.nocache" case.
>     Fix 048 case on tmpfs.
> 
> 
> Fam Zheng (6):
>   qemu-iotests: Add "-c <cache-mode>" option
>   qemu-iotests: Honour cache mode in iotests.py
>   qemu-iotests: Add _supported_cache_modes
>   qemu-iotests: Change default cache mode to "writeback"
>   qemu-iotests: Force qcow2 in error path test in 048
>   qemu-iotests: Clean up spaces in usage output
> 
>  tests/qemu-iotests/026        |  2 +-
>  tests/qemu-iotests/039        |  2 +-
>  tests/qemu-iotests/048        |  8 +++++++-
>  tests/qemu-iotests/052        |  3 +--
>  tests/qemu-iotests/check      |  2 +-
>  tests/qemu-iotests/common     | 37 +++++++++++++++++++++++++++----------
>  tests/qemu-iotests/common.rc  | 20 ++++++++++----------
>  tests/qemu-iotests/iotests.py |  3 ++-
>  8 files changed, 50 insertions(+), 27 deletions(-)

In principle I'm happy with the series but there are two instances where
you are silently changing what the test does (overriding cache mode and
image format).

Please skip tests that cannot run instead of silently testing something
else.

Stefan