From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjV6y-0000jg-Jy for qemu-devel@nongnu.org; Thu, 21 Nov 2013 09:20:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjV6t-0002Qs-Dc for qemu-devel@nongnu.org; Thu, 21 Nov 2013 09:20:04 -0500 Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]:47515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjV6t-0002Qh-6w for qemu-devel@nongnu.org; Thu, 21 Nov 2013 09:19:59 -0500 Received: by mail-wg0-f51.google.com with SMTP id l18so2309852wgh.6 for ; Thu, 21 Nov 2013 06:19:58 -0800 (PST) Date: Thu, 21 Nov 2013 15:19:55 +0100 From: Stefan Hajnoczi Message-ID: <20131121141955.GD7466@stefanha-thinkpad.redhat.com> References: <1384912916-18712-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384912916-18712-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 0/4] Use blkdebug to make test deterministic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com On Wed, Nov 20, 2013 at 10:01:52AM +0800, Fam Zheng wrote: > This adds "remove_break" command to block, which removes a break point defined > with "break". It is used in iotests.py to pause and resume drive in block job > cases to make the test deterministic. > > v6: [04] Fix 055 race condition by keeping sleep after resume_drive. (Stefan) > > v5: Addressing Max's comments (thanks for reviewing) > [02] Resume all the requests. > [03] Fix event="" case. Change default value to None. > Change resume to bool. > [04] Change resume to bool > > v4: [01] Added. > [03] Add common method pair "pause_drive" and "resume_drive". > [04] Also fix 040, 055. > > > Fam Zheng (4): > qemu-iotests: Drop local version of cancel_and_wait from 040 > blkdebug: add "remove_break" command > qemu-iotest: Add pause_drive and resume_drive methods > qemu-iotests: Make test case 030, 040 and 055 deterministic > > block.c | 13 +++++++++++++ > block/blkdebug.c | 27 +++++++++++++++++++++++++++ > include/block/block.h | 1 + > include/block/block_int.h | 2 ++ > qemu-io-cmds.c | 22 ++++++++++++++++++++++ > tests/qemu-iotests/030 | 16 +++++++++++----- > tests/qemu-iotests/040 | 19 +++---------------- > tests/qemu-iotests/055 | 14 +++++++++++--- > tests/qemu-iotests/iotests.py | 18 +++++++++++++++++- > 9 files changed, 107 insertions(+), 25 deletions(-) I ran 055 successfully 6 times in a row, the issue seems to be gone. Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan