From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjvPb-0005r5-Bu for qemu-devel@nongnu.org; Fri, 22 Nov 2013 13:25:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjvPV-0004YO-Iw for qemu-devel@nongnu.org; Fri, 22 Nov 2013 13:25:03 -0500 Received: from mail-pb0-f44.google.com ([209.85.160.44]:44137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjvPV-0004YJ-Ch for qemu-devel@nongnu.org; Fri, 22 Nov 2013 13:24:57 -0500 Received: by mail-pb0-f44.google.com with SMTP id rq2so1653313pbb.31 for ; Fri, 22 Nov 2013 10:24:56 -0800 (PST) Date: Fri, 22 Nov 2013 10:26:24 -0800 From: Christoffer Dall Message-ID: <20131122182624.GO9314@cbox> References: <1385140638-10444-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1385140638-10444-1-git-send-email-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH v9 00/11] target-arm: mach virt and -cpu host support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: patches@linaro.org, qemu-devel@nongnu.org, kvmarm@lists.cs.columbia.edu On Fri, Nov 22, 2013 at 05:17:07PM +0000, Peter Maydell wrote: > This patchset combines the 'virt' machine definition and > -cpu host support patchsets I've posted previous versions > of. I think these are now ready to go in once 1.8 opens > up; review appreciated. > > Changes since previous versions: > * added in -cpu host patchset, since it really only makes > sense with mach-virt > * rearranged virt address space a bit to allow space > for a reasonable sized boot flash device and possible > PCI window if a PCI controller model ever becomes possible > * fixed bug where we weren't starting secondary CPUs in > "PSCI power-down" state (by adding a CPU property which > lets the board specify that the CPU starts powered down) > [thanks to Giridhar Maruthy for tracking this down] > * includes a KVM header update against current mainline > * includes (previously RFC'd) patch which provides defines > of some kernel KVM constants we can use even if not CONFIG_KVM > * put the KVM CPU type into the CPU object rather than having > a silly 'QOM object type => constant' lookup table > * put dtb 'compatible' string into CPU object rather than > having the board model need to know about it > * abstracted out the "create a scratch vcpu for querying > for capabilities" code; this is currently only called in > one place, but the abstraction will be needed for 64 bit > KVM ARM support > > Mostly this is cleanup and streamlining which I noticed > was either possible or necessary in the course of putting > 64 bit KVM ARM control on top of this patchset. > > > The kernel patch to get the PL011 to work is still needed > (Christoffer tells me he's working on getting a proper fix > done for this): > I tell myself that too... Anyway, looked over the series and it looks good to me. So except for some of the QOM that I can't really wrap around my brain yet: Reviewed-by: Christoffer Dall