From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42931)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1Vjvw7-0008V0-IV
	for qemu-devel@nongnu.org; Fri, 22 Nov 2013 13:58:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1Vjvw1-0005hc-Oq
	for qemu-devel@nongnu.org; Fri, 22 Nov 2013 13:58:39 -0500
Received: from mail-pa0-f47.google.com ([209.85.220.47]:62594)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christoffer.dall@linaro.org>) id 1Vjvw1-0005hY-Iw
	for qemu-devel@nongnu.org; Fri, 22 Nov 2013 13:58:33 -0500
Received: by mail-pa0-f47.google.com with SMTP id kq14so1698093pab.34
	for <qemu-devel@nongnu.org>; Fri, 22 Nov 2013 10:58:32 -0800 (PST)
Date: Fri, 22 Nov 2013 11:00:01 -0800
From: Christoffer Dall <christoffer.dall@linaro.org>
Message-ID: <20131122190001.GP9314@cbox>
References: <1385140638-10444-1-git-send-email-peter.maydell@linaro.org>
	<1385140638-10444-11-git-send-email-peter.maydell@linaro.org>
	<20131122182502.GN9314@cbox>
	<CAFEAcA-6suwCNV7Q3zOX7V578bX5RMJtNZi79zGUg1_PAVystg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-6suwCNV7Q3zOX7V578bX5RMJtNZi79zGUg1_PAVystg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v9 10/11] target-arm: Provide '-cpu host'
	when running KVM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Patch Tracking <patches@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>

On Fri, Nov 22, 2013 at 06:50:47PM +0000, Peter Maydell wrote:
> On 22 November 2013 18:25, Christoffer Dall <christoffer.dall@linaro.org> wrote:
> > On Fri, Nov 22, 2013 at 05:17:17PM +0000, Peter Maydell wrote:
> >> +bool kvm_arm_create_scratch_host_vcpu(const uint32_t *cpus_to_try,
> >> +                                      int *fdarray,
> >> +                                      struct kvm_vcpu_init *init);
> >
> > why do we need to export this at all?
> 
> For 64 bit KVM support the 32 bit code moves into kvm32.c
> and then we have two users of this function, one in
> kvm32.c and one in kvm64.c. It seemed easiest to just
> make the function public with the proper doc comment
> from the start, rather than starting it private and
> then having a patch which makes it public.
> 
Yes, that does make sense.

Thanks.