From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkXsM-0005Rr-Eh for qemu-devel@nongnu.org; Sun, 24 Nov 2013 06:29:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkXsI-0004Vv-1M for qemu-devel@nongnu.org; Sun, 24 Nov 2013 06:29:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkXsH-0004Vr-Qf for qemu-devel@nongnu.org; Sun, 24 Nov 2013 06:29:13 -0500 Date: Sun, 24 Nov 2013 13:32:29 +0200 From: "Michael S. Tsirkin" Message-ID: <20131124113229.GB7528@redhat.com> References: <1385062405-3800-1-git-send-email-marcel.a@redhat.com> <528E791E.2010105@rdsoftware.de> <1385069438.5379.18.camel@localhost.localdomain> <528E7DDB.8000105@rdsoftware.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <528E7DDB.8000105@rdsoftware.de> Subject: Re: [Qemu-devel] [PATCH for-1.7 0/5] acpi unit-test: added tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Erik Rull Cc: qemu-devel@nongnu.org, Marcel Apfelbaum On Thu, Nov 21, 2013 at 10:40:43PM +0100, Erik Rull wrote: > Marcel Apfelbaum wrote: > >On Thu, 2013-11-21 at 22:20 +0100, Erik Rull wrote: > >>Marcel Apfelbaum wrote: > >>>Added 2 tests: > >>> 1. Basic check of FACS table (missed on prev submission) > >>> 2. Compare DSDT and SSDT tables against expected values > >>> > >>>Test 2: > >>> - runs only if iasl is installed on the host machine. > >>> - the test plan: > >>> 1. Dumps the ACPI tables as AML on the disk. > >>> 2. Runs iasl to disassembly the tables into ASL files. > >>> 3. Compares them with expected offline ASL files. > >>> > >>> - the test runs for both default machine and q35. > >>> - in case the test fails, it can be easily tweaked to > >>> show the differences between the ASL files and > >>> understand the issue. > >>> > >>>Patches: > >>> 1/5 - test 1 > >>> 2/5 - some infrastructure improvements > >>> 3/5 - expected asl files for test 2 > >>> 4/5 - creates links for the expected files > >>> if the build directory is not current > >>> 5/5 - test 2 > >>> > >> > >>Which iasl Version is needed for the ACPI compilation and testing? I have > >>an IASL installed on my build machine, but when trying to compile the ACPI > >>stuff, it fails. Maybe it's just too old, but I didn't find a way to > >>disable the iasl access. Must I uninstall iasl on my machine to get qemu > >>compiled again? > >I would use the latest version, version 20130823, from https://acpica.org/downloads > >or the git from git://github.com/acpica/acpica.git > > > >I don't think you need iasl on your computer to build qemu. > > > >Hope I helped, > >Marcel > > Thanks. > But then I don't understand the error that appears: > > CPP x86_64-softmmu/acpi-dsdt.dsl.i.orig > ACPI_PREPROCESS x86_64-softmmu/acpi-dsdt.dsl.i > IASL x86_64-softmmu/acpi-dsdt.dsl.i > make[1]: *** [hw/i386/acpi-dsdt.hex] Error 1 > make: *** [subdir-x86_64-softmmu] Error 2 It's because your IASL is present but appears broken. I can't say what's broken just from the version you give - building a source with matching version from debian gave me a working iasl. > I don't find a chance to disable this access/compilation within > configure. If I just missed a possible option, it would be great to > point me at it. I responded to this on a separate thread. > I found also when grep'ing through the sources that there is an "if" > for check whether iasl is present or not. But setting --iasl= > (empty) to force a removal of iasl for the qemu compilation gives a > configure error. > > Best regards, > > Erik > Yes, it's a configure bug. I sent a patch to fix this. > > > > >>The IASL version is: > >>Intel ACPI Component Architecture > >>ASL Optimizing Compiler version 20060912 [Dec 20 2006] > >>Copyright (C) 2000 - 2006 Intel Corporation > >>Supports ACPI Specification Revision 3.0a > >> > >>Thanks for your support. > >> > >>Best regards, > >> > >>Erik > >> > >> > >> > > > > > > > > >