From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39085)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VkZuU-0000Es-BK
	for qemu-devel@nongnu.org; Sun, 24 Nov 2013 08:39:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VkZuM-0003au-Fj
	for qemu-devel@nongnu.org; Sun, 24 Nov 2013 08:39:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:63754)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VkZuM-0003ao-7y
	for qemu-devel@nongnu.org; Sun, 24 Nov 2013 08:39:30 -0500
Date: Sun, 24 Nov 2013 15:42:40 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131124134240.GA9769@redhat.com>
References: <20131124095239.GA30786@redhat.com>
	<1385298244.2177.25.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1385298244.2177.25.camel@localhost.localdomain>
Subject: Re: [Qemu-devel] [PATCH] configure: make it possible to disable IASL
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcel.a@redhat.com
Cc: Peter Maydell <peter.maydell@linaro.org>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

On Sun, Nov 24, 2013 at 03:04:04PM +0200, Marcel Apfelbaum wrote:
> On Sun, 2013-11-24 at 11:52 +0200, Michael S. Tsirkin wrote:
> > Useful for platforms with a broken IASL.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  configure | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/configure b/configure
> > index 0592ba7..d0a0abe 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1080,6 +1080,7 @@ echo "  --source-path=PATH       path of source code [$source_path]"
> >  echo "  --cross-prefix=PREFIX    use PREFIX for compile tools [$cross_prefix]"
> >  echo "  --cc=CC                  use C compiler CC [$cc]"
> >  echo "  --iasl=IASL              use ACPI compiler IASL [$iasl]"
> > +echo "                           iasl='' (empty string) disables ACPI compiler"
> >  echo "  --host-cc=CC             use C compiler CC [$host_cc] for code run at"
> >  echo "                           build time"
> >  echo "  --cxx=CXX                use C++ compiler CXX [$cxx]"
> > @@ -4269,7 +4270,7 @@ else
> >  fi
> >  echo "PYTHON=$python" >> $config_host_mak
> >  echo "CC=$cc" >> $config_host_mak
> > -if $iasl -h > /dev/null 2>&1; then
> > +if test "$iasl" && $iasl -h > /dev/null 2>&1; then
> >    echo "IASL=$iasl" >> $config_host_mak
> >  fi
> >  echo "CC_I386=$cc_i386" >> $config_host_mak
> 
> I tried to disable iasl without this patch and it worked for me...
> I used:
>     - [Qemu-devel] [PATCH] configure: make --iasl option actually work
>     - ./configure --iasl="" (or --iasl=)
> and it worked (no sign of IASL in config-host.mak)
> 
> I think this is because the prev test "$iasl -h > /dev/null 2>&1"
> fails of course.

By luck, yes.

So this is just a documentation patch: cleaner to document the
interface explicitly.
I'll make this clearer in the commit log.

> I don't get it how <test "$iasl"> helps if iasl is broken.
> Thanks,
> Marcel
> 
> 
> 

It doesn't but it creates an interface to disable iasl
for such configurations.