From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 4/6] commit: support commit active layer
Date: Mon, 25 Nov 2013 11:28:38 +0100 [thread overview]
Message-ID: <20131125102838.GA12954@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1381295983-18945-5-git-send-email-famz@redhat.com>
On Wed, Oct 09, 2013 at 01:19:41PM +0800, Fam Zheng wrote:
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 381ffbf..eb13707 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1910,9 +1910,11 @@
> #
> # @top: The file name of the backing image within the image chain,
> # which contains the topmost data to be committed down.
> -# Note, the active layer as 'top' is currently unsupported.
> #
> # If top == base, that is an error.
> +# If top == active, the job will not be completed by itself,
> +# user need to complete the job with block-job-complete
s/need/needs/
s/with block-job-complete/with the block-job-complete/
> +# command after getting the ready event. (Since 1.7)
s/1.7/1.8/
next prev parent reply other threads:[~2013-11-25 10:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 5:19 [Qemu-devel] [PATCH v5 0/6] block: allow commit active as top Fam Zheng
2013-10-09 5:19 ` [Qemu-devel] [PATCH v5 1/6] mirror: don't close target Fam Zheng
2013-10-09 5:19 ` [Qemu-devel] [PATCH v5 2/6] mirror: move base to MirrorBlockJob Fam Zheng
2013-10-09 5:19 ` [Qemu-devel] [PATCH v5 3/6] block: add commit_active_start() Fam Zheng
2013-10-09 5:19 ` [Qemu-devel] [PATCH v5 4/6] commit: support commit active layer Fam Zheng
2013-11-25 10:28 ` Stefan Hajnoczi [this message]
2013-10-09 5:19 ` [Qemu-devel] [PATCH v5 5/6] qemu-iotests: update test cases for commit active Fam Zheng
2013-11-25 10:35 ` Stefan Hajnoczi
2013-10-09 5:19 ` [Qemu-devel] [PATCH v5 6/6] commit: remove unused check Fam Zheng
2013-11-08 3:12 ` [Qemu-devel] [PATCH v5 0/6] block: allow commit active as top Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125102838.GA12954@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).