From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60559)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VktPQ-0006Gg-2Q
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:29:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VktPH-0008VK-Mf
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:28:52 -0500
Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:40181)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1VktPH-0008ST-FF
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:28:43 -0500
Received: by mail-we0-f176.google.com with SMTP id t61so3597351wes.35
	for <qemu-devel@nongnu.org>; Mon, 25 Nov 2013 02:28:42 -0800 (PST)
Date: Mon, 25 Nov 2013 11:28:38 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20131125102838.GA12954@stefanha-thinkpad.redhat.com>
References: <1381295983-18945-1-git-send-email-famz@redhat.com>
	<1381295983-18945-5-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1381295983-18945-5-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 4/6] commit: support commit active layer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Oct 09, 2013 at 01:19:41PM +0800, Fam Zheng wrote:
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 381ffbf..eb13707 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1910,9 +1910,11 @@
>  #
>  # @top:              The file name of the backing image within the image chain,
>  #                    which contains the topmost data to be committed down.
> -#                    Note, the active layer as 'top' is currently unsupported.
>  #
>  #                    If top == base, that is an error.
> +#                    If top == active, the job will not be completed by itself,
> +#                    user need to complete the job with block-job-complete

s/need/needs/
s/with block-job-complete/with the block-job-complete/

> +#                    command after getting the ready event. (Since 1.7)

s/1.7/1.8/