From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkt6g-0004sV-Qa for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:09:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vkt6a-0003Cg-Ql for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:09:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkt6a-0003CU-Ia for qemu-devel@nongnu.org; Mon, 25 Nov 2013 05:09:24 -0500 Date: Mon, 25 Nov 2013 11:09:00 +0100 From: Igor Mammedov Message-ID: <20131125110900.51a2083f@nial.usersys.redhat.com> In-Reply-To: <20131121144520.GA11783@redhat.com> References: <1385001528-12003-1-git-send-email-imammedo@redhat.com> <20131121062056.GD19005@redhat.com> <20131121143910.066abec9@nial.usersys.redhat.com> <20131121134327.GB27184@redhat.com> <20131121153755.5eb122ee@nial.usersys.redhat.com> <20131121144520.GA11783@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/27 RFC v7] ACPI memory hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com, stefanb@linux.vnet.ibm.com, hutao@cn.fujitsu.com, marcel.a@redhat.com, mjt@tls.msk.ru, armbru@redhat.com, qemu-devel@nongnu.org, vasilis.liaskovitis@profitbricks.com, quintela@redhat.com, chegu_vinod@hp.com, kraxel@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, lcapitulino@redhat.com, stefanha@redhat.com, afaerber@suse.de On Thu, 21 Nov 2013 16:45:20 +0200 "Michael S. Tsirkin" wrote: > On Thu, Nov 21, 2013 at 03:37:55PM +0100, Igor Mammedov wrote: > > On Thu, 21 Nov 2013 15:43:27 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Nov 21, 2013 at 02:39:10PM +0100, Igor Mammedov wrote: > > > > On Thu, 21 Nov 2013 08:20:56 +0200 > > > > "Michael S. Tsirkin" wrote: > > > > > > > > > On Thu, Nov 21, 2013 at 03:38:21AM +0100, Igor Mammedov wrote: > > > > > > --- > > > > > > What's new since v6: > > > > > > > > > > > > * DIMM device is split to backend and frontend. Therefore following > > > > > > command/options were added for supporting it: > > > > > > > > > > > > For memdev backend: > > > > > > CLI: -memdev-add > > > > > > Monitor/QMP: memdev-add > > > > > > with options: 'id' and 'size' > > > > > > For dimm frontend: > > > > > > option "size" became readonly, pulling it's size from attached backend > > > > > > added option "memdev" for specifying backend by 'id' > > > > > > > > > > > > * Added Q35 support > > > > > > * Added support for 32 bit guests > > > > > > * build for i386 emulator (not tested) > > > > > > > > > > OK so a large patchset so did not review yet. One question > > > > > due to the dependency on bios honouring etc/reserved-memory-end: is > > > > > there some way to detect old BIOS and fail memory hotplug? > > > > version negotiation between ASL and hardware could be used to that effect. > > > > > > > > QEMU could start with present but disabled memory hotplug and if > > > > QEMU and BIOS ASL could come in agreement that both support it in > > > > compatible way, it could be enabled. > > > > > > So at the moment there's no negotiation, is there? > > Nope, I surely can add it in next iteration. > > I'm not sure about this - if we add this we should make it > a generic mechanism I think. > It does not have to be part of this series. > So maybe drop version for now ... > Ok, I'll drop it for now.