From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkuQg-0002Wv-2W for qemu-devel@nongnu.org; Mon, 25 Nov 2013 06:34:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkuQa-0004pm-3V for qemu-devel@nongnu.org; Mon, 25 Nov 2013 06:34:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkuQZ-0004pd-RP for qemu-devel@nongnu.org; Mon, 25 Nov 2013 06:34:08 -0500 Date: Mon, 25 Nov 2013 13:37:17 +0200 From: "Michael S. Tsirkin" Message-ID: <20131125113717.GC31995@redhat.com> References: <20131124093704.GA26763@redhat.com> <5291DD42.1050603@weilnetz.de> <52931E28.8010800@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52931E28.8010800@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1.7] configure: re-add current options in config-host.mak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Maydell , Fam Zheng , Anthony Liguori , Stefan Weil , qemu-devel@nongnu.org, Stefan Hajnoczi , Richard Henderson On Mon, Nov 25, 2013 at 10:53:44AM +0100, Paolo Bonzini wrote: > Il 24/11/2013 12:04, Stefan Weil ha scritto: > > Do we really need this? It only makes git bisect iterations from > > versions after 2013-11-19 to versions before that date easier. If a > > typical git bisect needs 10 steps, then in the worst cast 5 of them > > won't automatically run configure. This is normally not a big problem > > because there is already a configuration, and many changes of file > > configure don't change that configuration. > > > > It's always possible to run configure explicitly at each step of the > > bisection process, so in case of doubt there is an easy fall-back > > solution. Before I introduced automatic reconfiguration, calling > > configure + make was normal for git bisect. > > > > I'd prefer to avoid code like this patch which is only marginally useful > > in a very specific development use case. People who can run git bisect > > will be able to help themselves if they really get a problem without the > > patch. > > I think anything that makes it easier for users to do bisections instead > of us, and anything that makes it easier to script bisections ("git > bisect run"), is valuable. > > Thanks Michael, patch > > Acked-by: Paolo Bonzini > > for 1.7 too. > > Paolo IMHO it's helpful but it's too late for controversial patches now. So I won't push this to Anthony unless Stefan reconsiders and acks. -- MST