From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkx07-0003ln-Cy for qemu-devel@nongnu.org; Mon, 25 Nov 2013 09:19:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vkx01-00056E-E1 for qemu-devel@nongnu.org; Mon, 25 Nov 2013 09:18:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vkx01-00055z-3h for qemu-devel@nongnu.org; Mon, 25 Nov 2013 09:18:53 -0500 Date: Mon, 25 Nov 2013 15:18:33 +0100 From: Igor Mammedov Message-ID: <20131125151833.41dc88b6@nial.usersys.redhat.com> In-Reply-To: <5293546B.1060900@redhat.com> References: <1385001528-12003-1-git-send-email-imammedo@redhat.com> <1385001528-12003-14-git-send-email-imammedo@redhat.com> <20131121094202.GB3140@redhat.com> <20131121152137.6348e9b2@nial.usersys.redhat.com> <20131121143847.GA11741@redhat.com> <20131122181446.4891e953@nial.usersys.redhat.com> <20131124105857.GA864@redhat.com> <87txf1kkjo.fsf@blackfin.pond.sub.org> <5293546B.1060900@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com, stefanb@linux.vnet.ibm.com, hutao@cn.fujitsu.com, "Michael S. Tsirkin" , mjt@tls.msk.ru, Markus Armbruster , qemu-devel@nongnu.org, vasilis.liaskovitis@profitbricks.com, quintela@redhat.com, chegu_vinod@hp.com, kraxel@redhat.com, aliguori@amazon.com, marcel.a@redhat.com, lcapitulino@redhat.com, stefanha@redhat.com, afaerber@suse.de On Mon, 25 Nov 2013 14:45:15 +0100 Paolo Bonzini wrote: > Il 25/11/2013 08:27, Markus Armbruster ha scritto: > > "Michael S. Tsirkin" writes: > > > > [...] > >> Here this made me think of the following question: > >> should not memory available on boot be listed in CMOS? > >> Let's assume new BIOS gets interrupt telling it there's new memory. > >> It clears the interrupt and then system is reset. > >> > >> Will system after reset detect the new hotplugged memory? > > Can it just scan all slots from MHPD._INI? > > For example on reset all slots could be disabled by the > ACPIHotpluggableDimmBus (even coldplugged ones), and scanned + enabled > by ASL. memory devices are scanned by OSPM during ACPI tables parsing and guest (can) use present devices right away. Currently I don't see necessity for enabling individual memory devices from ASL since it adds one more round trip for QEMU<->guest protocol for no particular benefit. The only use case Michael suggested would be running OLD BIOS (without memory hotplug support) on machine with actively used memory hotplug (if OLD BIOS runs on machine with memory hotplug but there is no hotplugged memory devices, it runs just fine), so case looks like not worth an effort and complexity it would bring. I believe having completely functional DIMM device after its realize() method is completed is more strait-forward and easier to understand/support than having guest to complete it's initialization. That would allow later to put present at boot DIMMs into E820 (way before ASL is executed) if that would be necessary and also help to convert initial memory into hotpluggable one as well. > > >> How? > > > > Do physical systems with hot-pluggable memory exist? How do they > > behave? > > I guess they assume BIOS is updated in lockstep with the introduction of > the feature. > > Paolo >