From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48443)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Vky08-0007Pp-65
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 10:23:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Vky01-000745-Rj
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 10:23:04 -0500
Received: from mx1.redhat.com ([209.132.183.28]:7844)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1Vky01-00073w-Ha
	for qemu-devel@nongnu.org; Mon, 25 Nov 2013 10:22:57 -0500
Date: Mon, 25 Nov 2013 15:39:13 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20131125153913.1af63baa@nial.usersys.redhat.com>
In-Reply-To: <20131121093701.GA3140@redhat.com>
References: <1385001528-12003-1-git-send-email-imammedo@redhat.com>
	<1385001528-12003-24-git-send-email-imammedo@redhat.com>
	<20131121093701.GA3140@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 23/27] pc: ACPI BIOS: implement memory
 hotplug interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@amazon.com, marcel.a@redhat.com, armbru@redhat.com, stefanb@linux.vnet.ibm.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, vasilis.liaskovitis@profitbricks.com, quintela@redhat.com, kraxel@redhat.com, stefanha@redhat.com, hutao@cn.fujitsu.com, pbonzini@redhat.com, lcapitulino@redhat.com, chegu_vinod@hp.com, afaerber@suse.de

On Thu, 21 Nov 2013 11:37:01 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Thu, Nov 21, 2013 at 03:38:44AM +0100, Igor Mammedov wrote:
> > - provides static SSDT object for memory hotplug
> > - SSDT template for memory devices and runtime generator
> >   of them in SSDT table.
> > 
> > Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
[...]

> > diff --git a/hw/i386/ssdt-misc.dsl b/hw/i386/ssdt-misc.dsl
> > index a4484b8..b0c581e 100644
> > --- a/hw/i386/ssdt-misc.dsl
> > +++ b/hw/i386/ssdt-misc.dsl
> > @@ -116,4 +116,183 @@ DefinitionBlock ("ssdt-misc.aml", "SSDT", 0x01, "BXPC", "BXSSDTSUSP", 0x1)
> >              }
> >          }
> >      }
> > +
> > +    External(MTFY, MethodObj)
> > +
> > +    Scope(\_SB) {
> > +        Device(MHPD) {
> > +            Name(_HID, EISAID("PNP0C08"))
> > +
> > +            ACPI_EXTRACT_NAME_WORD_CONST ssdt_mctrl_port
> > +            Name(MHPP, 0xFFFF)
> > +
> > +            ACPI_EXTRACT_NAME_DWORD_CONST ssdt_mctrl_nr_slots
> > +            Name(MDNR, 0x12345678)
> > +
> > +            /* Memory hotplug IO registers */
> > +            OperationRegion(HPMR, SystemIO, MHPP, 24)
> > +
> > +            Method(_CRS, 0, Serialized) {
> > +                Name(CRS, ResourceTemplate() {
> > +                    IO(Decode16, 0x00, 0x00, 0x01, 24, IO)
> > +                })
> 
> 
> Declaring name makes us serialize it.
> Can't we use a local variable?
If that works, I'll change it.

But I have a question of my own perhaps to Paolo or Gerd,
Do we really need this _CRS, because if you look at next hunk
_STA should report not present but functioning to avoid windows BSOD.
So there is not guaranties that OSPM would care or even query it
and honor _CRS provided range.


[...]
> > +
> > +            Method(_STA, 0) {
> > +                If (LEqual(MDNR, Zero)) {
> > +                    Return(0x0)
> > +                }
> > +                /* Leave bit 0 cleared to avoid Windows BSOD */
> > +                Return(0xA)
> > +            }
[...]