From: "Michael S. Tsirkin" <mst@redhat.com>
To: Richard Henderson <rth@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL for-1.7 v2 3/6] acpi-build: fix build on glib < 2.22
Date: Mon, 25 Nov 2013 23:33:12 +0200 [thread overview]
Message-ID: <20131125213312.GB13692@redhat.com> (raw)
In-Reply-To: <5293BF70.3030704@redhat.com>
On Tue, Nov 26, 2013 at 07:21:52AM +1000, Richard Henderson wrote:
> On 11/26/2013 07:02 AM, Michael S. Tsirkin wrote:
> > In any case it's too late to play with cosmetic changes for 1.7.
> > We can revisit for 1.8.
>
> I beg your pardon? I didn't realize your patch had already been applied.
When you see PATCH you should review.
When you see PULL it's been applied and pushed
to a public branch.
> And
> since it has mistakes that require respin anyway, why can't we change this too?
>
>
> r~
The patch we discuss is correct, the patch removing get element
size didn't remove it in all places, but it's not making
things any worse so I'll fix them with applying a patch on top.
I queued other things on top and it's 11:30pm here.
Guys, go discuss the color of some other bikeshed.
--
MST
next prev parent reply other threads:[~2013-11-25 21:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 11:48 [Qemu-devel] [PULL for-1.7 v2 0/5] pc very last minute fixes for 1.7 Michael S. Tsirkin
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 1/6] s390x: fix flat file load on 32 bit systems Michael S. Tsirkin
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 2/6] pci: unregister vmstate_pcibus on unplug Michael S. Tsirkin
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 3/6] acpi-build: fix build on glib < 2.22 Michael S. Tsirkin
2013-11-25 20:24 ` Richard Henderson
2013-11-25 20:31 ` Michael S. Tsirkin
2013-11-25 20:37 ` Richard Henderson
2013-11-25 20:54 ` Michael S. Tsirkin
2013-11-25 21:15 ` Laszlo Ersek
2013-11-25 21:22 ` Eric Blake
2013-11-25 21:18 ` Richard Henderson
2013-11-25 21:26 ` Michael S. Tsirkin
2013-11-25 21:02 ` Michael S. Tsirkin
2013-11-25 21:21 ` Richard Henderson
2013-11-25 21:33 ` Michael S. Tsirkin [this message]
2013-11-25 21:57 ` Laszlo Ersek
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 4/6] acpi-build: fix build on glib < 2.14 Michael S. Tsirkin
2013-11-25 20:14 ` Erik Rull
2013-11-25 20:59 ` Michael S. Tsirkin
2013-11-25 21:01 ` Michael S. Tsirkin
2013-11-25 21:47 ` Richard Henderson
2013-11-25 22:41 ` Erik Rull
2013-11-25 20:26 ` Richard Henderson
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 5/6] Revert "e1000/rtl8139: update HMP NIC when every bit is written" Michael S. Tsirkin
2013-11-25 11:48 ` [Qemu-devel] [PULL for-1.7 v2 6/6] configure: make --iasl option actually work Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125213312.GB13692@redhat.com \
--to=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).