From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35012)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1VlL2q-0006Ub-DW
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 10:59:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1VlL2k-00031a-EZ
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 10:59:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:13103)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mtosatti@redhat.com>) id 1VlL2j-00030q-PG
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 10:59:18 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAQFxF3B010356
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 26 Nov 2013 10:59:16 -0500
Date: Mon, 25 Nov 2013 21:09:53 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20131125230953.GA550@amt.cnet>
References: <1385401393-14291-1-git-send-email-pbonzini@redhat.com>
	<20131125210510.GL12689@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131125210510.GL12689@redhat.com>
Subject: Re: [Qemu-devel] [PATCH rebased for-1.8] i386: pc: align gpa<->hpa
 on 1GB boundary (v6)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On Mon, Nov 25, 2013 at 11:05:10PM +0200, Michael S. Tsirkin wrote:
> On Mon, Nov 25, 2013 at 06:43:13PM +0100, Paolo Bonzini wrote:
> > v2: condition enablement of new mapping to new machine types (Paolo)
> > v3: fix changelog
> > v4: rebase
> > v5: ensure alignment of piecetwo on 2MB GPA (Igor)
> >     do not register zero-sized piece-one    (Igor)
> > v6: fix memory leak                         (Igor)
> >     fix integer overflow                    (Igor)
> > 
> > ----
> > 
> > Align guest physical address and host physical address
> > beyond guest 4GB on a 1GB boundary.
> > 
> > Otherwise 1GB TLBs cannot be cached for the range.
> > 
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> > [Reorganize code, keep same logic. - Paolo]
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> BTW how about a unit-test for this?
> Can be something along the lines of the acpi tests:
> run BIOS, probe what it reported.

There is no guest visible difference.