From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VlEc2-00032q-EX
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 04:07:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VlEbs-0003Qc-MO
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 04:07:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36535)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1VlEbs-0003QE-EN
	for qemu-devel@nongnu.org; Tue, 26 Nov 2013 04:07:08 -0500
Date: Tue, 26 Nov 2013 11:10:14 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20131126091014.GA18777@redhat.com>
References: <1384775449-6693-1-git-send-email-mst@redhat.com>
	<1384775449-6693-2-git-send-email-mst@redhat.com>
	<52945802.2010309@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52945802.2010309@redhat.com>
Subject: Re: [Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, "Jordan Justen (Intel address)" <jordan.l.justen@intel.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>, Igor Mammedov <imammedo@redhat.com>

On Tue, Nov 26, 2013 at 09:12:50AM +0100, Laszlo Ersek wrote:
> On 11/18/13 12:53, Michael S. Tsirkin wrote:
> > From: Igor Mammedov <imammedo@redhat.com>
> > 
> > The BIOS that we ship in 1.7 does not use pci info
> > from host and so far isn't going to use it.
> > Taking in account problems it caused see 9604f70fdf and
> > to avoid future incompatibility issues, it's safest to
> > disable that interface by default for all machine types
> > including 1.7 as it was never exposed/used by guest.
> > And properly remove/cleanup it during 1.8 development cycle.
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  hw/i386/pc_piix.c | 2 +-
> >  hw/i386/pc_q35.c  | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> etc/pci-info is precisely the form and contents that OVMF needs to
> download ACPI tables from qemu.
> 
> <http://sourceforge.net/mailarchive/forum.php?thread_name=1385450282-27007-3-git-send-email-lersek%40redhat.com&forum_name=edk2-devel>
> 
> Please keep this exported in 1.8, for OVMF's sake.
> 
> Thanks
> Laszlo

This pull request was misnamed, it was merged for 1.7.
Problem is pci-info can't be implemented correctly as defined:
for example we don't know where does MMCONFIG resize before
it is configured.
This patch was acked by several people so we'll need a stronger justification
for re-introducing it.
seabios manages to enumerate PCI with information exported from qemu
so why can't OVMF?

I think it's down to other qemu bugs (such as _CRS not covering
all of PCI memory), we shall just fix them.

-- 
MST