qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	"Jordan Justen (Intel address)" <jordan.l.justen@intel.com>,
	qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info
Date: Tue, 26 Nov 2013 17:48:40 +0200	[thread overview]
Message-ID: <20131126154840.GA22903@redhat.com> (raw)
In-Reply-To: <1385480536.10163.28.camel@nilsson.home.kraxel.org>

On Tue, Nov 26, 2013 at 04:42:16PM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > This doesn't clamp the w32.begin value into [0x80000000, 0xe0000000],
> > which seems wrong.
> 
> Why?  In a 1G guest you can map pci bars at 0x40000000 just fine.
> 
> _CRS in acpi should declare the area where you can map pci bars, and
> that happens to be end-of-ram -> ioapci base.
> 
> Firmware can choose to use a smaller area.  Both seabios and ovmf will
> not map anyting below 0x80000000.  That is just fine.  As long as all
> pci bars get mapped inside the region declared in _CRS things will work.
> 
> While thinking about it:  There is one possible reason to not do it:
> Guest bugs.  IIRC windows doesn't like the 64bit pci window being larger
> than 2G.
>  Possibly that is an issue with the 32bit window too.  If that
> is the case we should indeed not use w32.begin values smaller than
> 0x8000000.  Igor, any clue?

I think the issues are all around 64 bit.
It's not hard to test.

> > Guys, I'm confused and annoyed out of my brains by the divergence here.
> > In my perception Michael, Igor, and Gerd are all proposing different
> > things, and my ideas are either rejected or ignored (even though they
> > occasionally overlap with ideas from others).
> 
> Hmm, as far as I can see there is an agreement that it is qemu's fault,
> the acpi tables need fixing, and ovmf should not need changes any
> changes.
> 
> Mimicing seabios/qemu logic in ovmf can be used as temporary stopgap
> while details are sorted on the qemu side.
> 
> cheers,
>   Gerd
> 

  reply	other threads:[~2013-11-26 15:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 11:53 [Qemu-devel] [PULL for-1.8 0/2] pc last minute fixes for 1.8 Michael S. Tsirkin
2013-11-18 11:53 ` [Qemu-devel] [PULL for-1.8 1/2] pc: disable pci-info Michael S. Tsirkin
2013-11-26  8:12   ` Laszlo Ersek
2013-11-26  9:10     ` Michael S. Tsirkin
2013-11-26 11:00       ` Gerd Hoffmann
2013-11-26 14:04         ` Michael S. Tsirkin
2013-11-26 14:22           ` Laszlo Ersek
2013-11-26 15:04             ` Michael S. Tsirkin
2013-11-26 15:42             ` Gerd Hoffmann
2013-11-26 15:48               ` Michael S. Tsirkin [this message]
2013-11-26 18:26               ` Igor Mammedov
2013-11-27  6:15                 ` Michael S. Tsirkin
2013-11-26 15:20           ` Gerd Hoffmann
2013-11-26 15:28             ` Michael S. Tsirkin
2013-11-26 15:59               ` Gerd Hoffmann
2013-11-27  6:20                 ` Michael S. Tsirkin
2013-11-26 14:11       ` Laszlo Ersek
2013-11-26 18:58         ` Igor Mammedov
2013-11-18 11:53 ` [Qemu-devel] [PULL for-1.8 2/2] doc: fix hardcoded helper path Michael S. Tsirkin
2013-11-18 15:06 ` [Qemu-devel] [PULL for-1.8 0/2] pc last minute fixes for 1.8 Eric Blake
2013-11-18 15:17   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131126154840.GA22903@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jordan.l.justen@intel.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).