From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlT3a-0003tr-Qo for qemu-devel@nongnu.org; Tue, 26 Nov 2013 19:32:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlT3U-0000Ba-S0 for qemu-devel@nongnu.org; Tue, 26 Nov 2013 19:32:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlT3U-0000BQ-KR for qemu-devel@nongnu.org; Tue, 26 Nov 2013 19:32:36 -0500 Date: Wed, 27 Nov 2013 01:32:19 +0100 From: Igor Mammedov Message-ID: <20131127013219.58eac8b6@thinkpad> In-Reply-To: <529347B7.80409@redhat.com> References: <1385001528-12003-1-git-send-email-imammedo@redhat.com> <1385001528-12003-5-git-send-email-imammedo@redhat.com> <529347B7.80409@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com, mst@redhat.com, mjt@tls.msk.ru, stefanb@linux.vnet.ibm.com, stefanha@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, vasilis.liaskovitis@profitbricks.com, quintela@redhat.com, chegu_vinod@hp.com, kraxel@redhat.com, aliguori@amazon.com, hutao@cn.fujitsu.com, marcel.a@redhat.com, lcapitulino@redhat.com, afaerber@suse.de On Mon, 25 Nov 2013 13:51:03 +0100 Paolo Bonzini wrote: > Il 21/11/2013 03:38, Igor Mammedov ha scritto: > > Along with conversion extend -m option to support following parameters: > > "mem" - startup memory amount > > "slots" - total number of hotplug memory slots > > "maxmem" - maximum possible memory > > > > "slots" and "maxmem" should go in pair and "maxmem" should be greater > > than "mem" for memory hotplug to be usable. > > Strictly speaking, slots and maxmem should be added later, not in this > patch. Not a blocker, though. I've split patch taking in account most of Markus' comments and added extra error checks for option values. Amended patches are posted as reply to this thread. > Paolo > [...] -- Regards, Igor