From: Kevin Wolf <kwolf@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse backing HD for sync=none
Date: Wed, 27 Nov 2013 10:42:19 +0100 [thread overview]
Message-ID: <20131127094219.GA2884@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <87vbzfrqhw.fsf@codemonkey.ws>
Am 26.11.2013 um 19:02 hat Anthony Liguori geschrieben:
> Max Reitz <mreitz@redhat.com> writes:
>
> > This series fixes the drive-mirror blockjob in case of "none" sync mode
> > to always use the old (current) image file as the backing file of the
> > newly created mirrored file (in case of "absolute-paths" mode).
> >
> > It is rather important to get this into 1.7, as we will introduce an at
> > least pretty strange API in case the original file is unbacked
> > otherwise.
>
> Kevin/Stefan? Do we need this for 1.7?
Yes, it would be good to pick it up in order to avoid changing the API
in 1.8 (I guess we would do it anyway because the current behaviour
doesn't make any sense and we'd call it bug fix, but libvirt would have
to deal with it and better to do it right in the first release.)
Do you want to pick it up yourself or should I send a pull request?
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Kevin
next prev parent reply other threads:[~2013-11-27 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 19:28 [Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse backing HD for sync=none Max Reitz
2013-11-25 19:28 ` [Qemu-devel] [PATCH for-1.7 1/2] " Max Reitz
2013-11-25 19:37 ` Eric Blake
2013-11-25 19:28 ` [Qemu-devel] [PATCH for-1.7 2/2] qemu-iotests: Fix test 041 Max Reitz
2013-11-25 19:38 ` Eric Blake
2013-11-26 9:02 ` [Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse backing HD for sync=none Paolo Bonzini
2013-11-26 18:02 ` Anthony Liguori
2013-11-27 9:42 ` Kevin Wolf [this message]
2013-11-27 19:33 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127094219.GA2884@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).