From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm0DR-0006D1-58 for qemu-devel@nongnu.org; Thu, 28 Nov 2013 06:57:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vm0DM-0008O3-Dc for qemu-devel@nongnu.org; Thu, 28 Nov 2013 06:57:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm0DM-0008Ny-5G for qemu-devel@nongnu.org; Thu, 28 Nov 2013 06:57:00 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rASBuw9H023821 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Nov 2013 06:56:58 -0500 Date: Thu, 28 Nov 2013 12:56:54 +0100 From: Kevin Wolf Message-ID: <20131128115654.GB4805@dhcp-200-207.str.redhat.com> References: <1384914356-14231-1-git-send-email-famz@redhat.com> <5295528F.3080804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5295528F.3080804@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/2] qemu-iotests: Filter out "qemu-io> " in all tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com Am 27.11.2013 um 03:01 hat Fam Zheng geschrieben: > On 2013=E5=B9=B411=E6=9C=8820=E6=97=A5 10:25, Fam Zheng wrote: > >The second patch is too large as a mail, you can pull from: > > > > https://github.com/famz/qemu.git 035-filter-qemu-io > > > >v2: Rebase to current master. > > [01] Add Reviewed-by for Eric. > > [02] Update comment to describe the command for mechanical substi= tution. (Eric) >=20 > Kevin, would you like to take this one? I would, but this way it simply doesn't work. The '035-filter-qemu-io' branch in your repo is something, but certainly not this series. It may be some early RFC where you only fixed one case. I then found the 'iotests-filter-qemu-io' (which is already not what you said) branch and I almost would have applied it, but I noticed it's not exactly the same as this series; I suppose it's version 1. Eric reviewed _something_, but the two branches I found aren't what you sent, and he didn't specify the commit ID he reviewed, so I can't put his Reviewed-by tag anywhere, because I simply don't know what he looked at. Fam, can you push the _current_ version somewhere and tell me the correct branch name and commit ID? Eric, can you then tell me if this newly pushed code matches what you reviewed? Kevin