From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm2uC-0004uh-Vh for qemu-devel@nongnu.org; Thu, 28 Nov 2013 09:49:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vm2u8-0004tg-2d for qemu-devel@nongnu.org; Thu, 28 Nov 2013 09:49:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm2u7-0004tT-Rg for qemu-devel@nongnu.org; Thu, 28 Nov 2013 09:49:20 -0500 Date: Thu, 28 Nov 2013 15:49:15 +0100 From: Kevin Wolf Message-ID: <20131128144915.GF4805@dhcp-200-207.str.redhat.com> References: <1384914356-14231-1-git-send-email-famz@redhat.com> <5295528F.3080804@redhat.com> <20131128115654.GB4805@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/2] qemu-iotests: Filter out "qemu-io> " in all tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Fam Zheng , "qemu-devel@nongnu.org" , Stefan Hajnoczi Am 28.11.2013 um 15:34 hat Fam Zheng geschrieben: > On Thu, Nov 28, 2013 at 7:56 PM, Kevin Wolf wrote: > > Am 27.11.2013 um 03:01 hat Fam Zheng geschrieben: > >> On 2013=E5=B9=B411=E6=9C=8820=E6=97=A5 10:25, Fam Zheng wrote: > >> >The second patch is too large as a mail, you can pull from: > >> > > >> > https://github.com/famz/qemu.git 035-filter-qemu-io > >> > > >> >v2: Rebase to current master. > >> > [01] Add Reviewed-by for Eric. > >> > [02] Update comment to describe the command for mechanical sub= stitution. (Eric) > >> > >> Kevin, would you like to take this one? > > > > I would, but this way it simply doesn't work. > > > > The '035-filter-qemu-io' branch in your repo is something, but certai= nly > > not this series. It may be some early RFC where you only fixed one ca= se. > > I then found the 'iotests-filter-qemu-io' (which is already not what = you > > said) branch and I almost would have applied it, but I noticed it's n= ot > > exactly the same as this series; I suppose it's version 1. > > > > Eric reviewed _something_, but the two branches I found aren't what y= ou > > sent, and he didn't specify the commit ID he reviewed, so I can't put > > his Reviewed-by tag anywhere, because I simply don't know what he loo= ked > > at. > > > > Fam, can you push the _current_ version somewhere and tell me the > > correct branch name and commit ID? Eric, can you then tell me if this > > newly pushed code matches what you reviewed? >=20 > Sorry, I've pushed again to: >=20 > https://github.com/famz/qemu.git for-kevin >=20 > Please fetch again. Thanks, cherry-picked the patches from that branch (commit ID of the top is 0974950e05137c7751ec1d3c5d1b0fa5387eead9). I didn't add Eric's Reviewed-by yet, but I'll do so when he confirms that this is what he checked. Kevin