From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmKW8-0004sQ-PS for qemu-devel@nongnu.org; Fri, 29 Nov 2013 04:37:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmKW3-0007V3-UT for qemu-devel@nongnu.org; Fri, 29 Nov 2013 04:37:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmKW3-0007Uv-Md for qemu-devel@nongnu.org; Fri, 29 Nov 2013 04:37:39 -0500 Date: Fri, 29 Nov 2013 10:37:35 +0100 From: Kevin Wolf Message-ID: <20131129093735.GB2887@dhcp-200-207.str.redhat.com> References: <1384914356-14231-1-git-send-email-famz@redhat.com> <5295528F.3080804@redhat.com> <20131128115654.GB4805@dhcp-200-207.str.redhat.com> <20131128144915.GF4805@dhcp-200-207.str.redhat.com> <52978416.4000606@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0OAP2g/MAC+5xKAE" Content-Disposition: inline In-Reply-To: <52978416.4000606@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/2] qemu-iotests: Filter out "qemu-io> " in all tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Fam Zheng , Fam Zheng , "qemu-devel@nongnu.org" , Stefan Hajnoczi --0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 28.11.2013 um 18:57 hat Eric Blake geschrieben: > On 11/28/2013 07:49 AM, Kevin Wolf wrote: >=20 > >>>>> https://github.com/famz/qemu.git 035-filter-qemu-io > >>>>> > >>>>> v2: Rebase to current master. > >>>>> [01] Add Reviewed-by for Eric. > >>>>> [02] Update comment to describe the command for mechanical subs= titution. (Eric) > >>>> > >>>> Kevin, would you like to take this one? > >>> > >>> I would, but this way it simply doesn't work. > >>> > >>> The '035-filter-qemu-io' branch in your repo is something, but certai= nly > >>> not this series. It may be some early RFC where you only fixed one ca= se. > >>> I then found the 'iotests-filter-qemu-io' (which is already not what = you > >>> said) branch and I almost would have applied it, but I noticed it's n= ot > >>> exactly the same as this series; I suppose it's version 1. > >>> > >>> Eric reviewed _something_, but the two branches I found aren't what y= ou > >>> sent, and he didn't specify the commit ID he reviewed, so I can't put > >>> his Reviewed-by tag anywhere, because I simply don't know what he loo= ked > >>> at. >=20 > And I've since lost track of which commit id I reviewed. >=20 > >>> > >>> Fam, can you push the _current_ version somewhere and tell me the > >>> correct branch name and commit ID? Eric, can you then tell me if this > >>> newly pushed code matches what you reviewed? > >> > >> Sorry, I've pushed again to: > >> > >> https://github.com/famz/qemu.git for-kevin > >> > >> Please fetch again. > >=20 > > Thanks, cherry-picked the patches from that branch (commit ID of the > > top is 0974950e05137c7751ec1d3c5d1b0fa5387eead9). I didn't add Eric's > > Reviewed-by yet, but I'll do so when he confirms that this is what he > > checked. >=20 > I have now reviewed commit 0974950e05137c7751ec1d3c5d1b0fa5387eead9 in > the same manner as before (manually followed the 'sed' instructions in > the commit message and verified that the only differences remaining are > the added filter). It appears that the only differences in this known > commit id from whatever (now unknown) commit I first reviewed is thus > limited to rebase differences. I'm happy with the commit, so feel free > to (re-)add: >=20 > Reviewed-by: Eric Blake Thanks, Eric, I've added it back now. Kevin --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBAgAGBQJSmGBfAAoJEH8JsnLIjy/WrBgP/i3fVeyO+kbyMdGXP3XGBUmr OUT794KxsbF1CKnI+N+OTgs4dnjsEDFu/AWjIt4r59D488OLGhd3HjSmj5iM0PMJ VYKlMqZHH/LL0gevfIV5YiJv2Ry1P7HayGgTbyDunX+b1p797mCizLbhR3+/rQwO 7kdFbdZgyfLDdd97xg8aa4W0+Il6tbr27qNo0bMzMcEgRB9DE3DHSHEhwBqPqOp1 HpiYxVzqTTh6Noy8++/JUzW/xTdo6mdemqvphTsFwMLpBr4G91ZCoR95zdewQqrt lTwSUaoqnwiEkNWwhz3L6T5/TZ7rlwELU5t9WguFHDQh8tPO73woeLTC03XiMgI+ f4UACkm/jcgqSgBWfT+snk50pdY27i9RD+pwji2DBh/jXZVzoRSRPO1TVh5jatPd SdPRhxwZ+JVoihsBDtwjz3s4oKEhxO6Bea2r/J1skpfKSrbuiIP/n8Cf7QplNTDG IaapHPHGOvC4lolQUY+0/pRiSv52pB/r3NwHSfulG5BNjnLd+AAAWH0O5X+lVF9J Y3arKk08SinElkFtMZW3qxxwk3tVCrLRFfKV6m/njI+2vBkU6oepeGhylH4wfhca riR7luev/4122WBsdOcRzbwg/5LWP73jSaIEBrzkJiNMdMh8Ue3h2Z7K5nix7HoN 9ugf1VXpmGyEPa+aw/mu =tcxR -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE--