From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block: Close backing file early in bdrv_img_create
Date: Mon, 2 Dec 2013 11:33:12 +0100 [thread overview]
Message-ID: <20131202103312.GE2845@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1385757689-23524-1-git-send-email-mreitz@redhat.com>
Am 29.11.2013 um 21:41 hat Max Reitz geschrieben:
> Leaving the backing file open although it is not needed anymore can
> cause problems if it is opened through a block driver which allows
> exclusive access only and if the create function of the block driver
> used for the top image (the one being created) tries to close and reopen
> the image file (which will include opening the backing file a second
> time).
>
> In particular, this will happen with a backing file opened through
> qemu-nbd and using qcow2 as the top image file format (which reopens the
> image to flush it to disk).
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> v2:
> - Minimizing the changes prevents introducing a leak of the
> BlockDriverState in case of an error in bdrv_open() (thanks, Kevin).
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
prev parent reply other threads:[~2013-12-02 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 20:41 [Qemu-devel] [PATCH v2] block: Close backing file early in bdrv_img_create Max Reitz
2013-11-29 22:01 ` Benoît Canet
2013-12-02 3:37 ` Wenchao Xia
2013-12-02 13:05 ` Stefan Hajnoczi
2013-12-02 10:33 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202103312.GE2845@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).