From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnlZ0-0006oT-Rz for qemu-devel@nongnu.org; Tue, 03 Dec 2013 03:42:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnlYp-0004tO-Fz for qemu-devel@nongnu.org; Tue, 03 Dec 2013 03:42:38 -0500 Date: Tue, 3 Dec 2013 09:42:23 +0100 From: Stefan Hajnoczi Message-ID: <20131203084223.GA12840@stefanha-thinkpad.muc.redhat.com> References: <1385953280-7390-1-git-send-email-famz@redhat.com> <20131202132617.GA28132@stefanha-thinkpad.redhat.com> <529D41FA.2060705@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <529D41FA.2060705@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] vmdk: Fix creating big description file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org On Tue, Dec 03, 2013 at 10:29:14AM +0800, Fam Zheng wrote: > On 2013=E5=B9=B412=E6=9C=8802=E6=97=A5 21:26, Stefan Hajnoczi wrote: > >On Mon, Dec 02, 2013 at 11:01:20AM +0800, Fam Zheng wrote: > >>The buffer for description file was 4096 which only covers a few > >>hundred of extents. This changes the buffer to dynamic allocated with > >>g_strdup_printf in order to support bigger cases. > >> > >>Signed-off-by: Fam Zheng > >>--- > >> block/vmdk.c | 65 +- > >> tests/qemu-iotests/059 | 5 + > >> tests/qemu-iotests/059.out | 2012 +++++++++++++++++++++++++++++++++= +++++++++++ > >> 3 files changed, 2058 insertions(+), 24 deletions(-) > > > >Does VMware have a hard limit? For example, does it open the 1000 GB > >twoGbMaxExtentFlat file from your test case? > > >=20 > Yes it does. The limit is far above this, there is a statement in > VMDK spec: "Maximum VMDK file size is 2TB." It opens this file from > the test case, however I can't generate such a twoGbMaxExtentFlat > from Workstation, because it will be automatically forced to > monolithicFlat (if the size is above certain threshold). Okay, good. Thanks for explaining. Stefan