From: Stefan Hajnoczi <stefanha@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes
Date: Tue, 3 Dec 2013 10:19:39 +0100 [thread overview]
Message-ID: <20131203091939.GB13747@stefanha-thinkpad.muc.redhat.com> (raw)
In-Reply-To: <529D74AC.5060008@linux.vnet.ibm.com>
On Tue, Dec 03, 2013 at 02:05:32PM +0800, Wenchao Xia wrote:
> This patch override only when default is specified, I am +1 with it.
> I think we had discuss before, just want a double check, stefan, do you
> agree with this?
Yes, I'm happy with this.
I just want to avoid test cases with custom code that silently changes
settings. As long as the default cache mode is declarative it's fine:
_default_cache_mode "writethrough"
next prev parent reply other threads:[~2013-12-03 9:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 1:43 [Qemu-devel] [PATCH v4 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback" Fam Zheng
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 1/6] qemu-iotests: Add "-c <cache-mode>" option Fam Zheng
2013-12-03 6:31 ` Wenchao Xia
2013-12-03 7:43 ` Fam Zheng
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 2/6] qemu-iotests: Honour cache mode in iotests.py Fam Zheng
2013-12-03 5:35 ` Wenchao Xia
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes Fam Zheng
2013-12-03 6:05 ` Wenchao Xia
2013-12-03 8:21 ` Fam Zheng
2013-12-03 9:28 ` Kevin Wolf
2013-12-03 10:33 ` Fam Zheng
2013-12-03 9:19 ` Stefan Hajnoczi [this message]
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 4/6] qemu-iotests: Change default cache mode to "writeback" Fam Zheng
2013-12-03 6:28 ` Wenchao Xia
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 5/6] qemu-iotests: Clean up spaces in usage output Fam Zheng
2013-12-03 6:28 ` Wenchao Xia
2013-11-26 1:43 ` [Qemu-devel] [PATCH v4 6/6] qemu-iotests: Split qcow2 only cases in 048 Fam Zheng
2013-12-03 9:56 ` [Qemu-devel] [PATCH v4 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback" Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203091939.GB13747@stefanha-thinkpad.muc.redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).