From: Stefan Hajnoczi <stefanha@gmail.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH V6 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case
Date: Tue, 3 Dec 2013 14:45:23 +0100 [thread overview]
Message-ID: <20131203134523.GC24604@stefanha-thinkpad.muc.redhat.com> (raw)
In-Reply-To: <1385094432-1655-4-git-send-email-xiawenc@linux.vnet.ibm.com>
On Fri, Nov 22, 2013 at 12:27:09PM +0800, Wenchao Xia wrote:
> +nbd_snapshot_port=10850
> +nbd_snapshot_img="nbd:127.0.0.1:$nbd_snapshot_port"
> +
> +_export_nbd_snapshot()
> +{
> + $QEMU_NBD -v -t -b 127.0.0.1 -p $nbd_snapshot_port "$TEST_IMG" -l $1 &
Please use a UNIX domain socket so that multiple qemu-iotests instances
can run on the same host in parallel. The socket should be in the
scratch directory just like the temporary image files.
> + NBD_SNAPSHOT_PID=$!
> + sleep 1
qemu-nbd might not start within 1 second on a heavily loaded host.
To make this test case reliable please use a loop (e.g. wait for UNIX
domain socket to appear for up to 30 seconds).
If you feel qemu-nbd doesn't offer a good interface for reliable
startup, feel free to extend it. Test cases must be reliable and
ideally shouldn't waste time sleeping.
next prev parent reply other threads:[~2013-12-03 13:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 4:27 [Qemu-devel] [PATCH V6 0/6] export internal snapshot by qemu-nbd Wenchao Xia
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 1/6] snapshot: distinguish id and name in load_tmp Wenchao Xia
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 2/6] qemu-nbd: support internal snapshot export Wenchao Xia
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case Wenchao Xia
2013-12-03 13:45 ` Stefan Hajnoczi [this message]
2013-12-04 2:52 ` Wenchao Xia
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 4/6] qemu-img: add -l for snapshot in convert Wenchao Xia
2013-12-03 11:02 ` Stefan Hajnoczi
2013-12-04 2:50 ` Wenchao Xia
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 5/6] qemu-iotests: add test for snapshot in qemu-img convert Wenchao Xia
2013-11-22 4:27 ` [Qemu-devel] [PATCH V6 6/6] qemu-nbd: add doc for option -f Wenchao Xia
2013-11-29 8:54 ` [Qemu-devel] [PATCH V6 0/6] export internal snapshot by qemu-nbd Wenchao Xia
2013-12-03 3:33 ` Wenchao Xia
2013-12-03 13:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203134523.GC24604@stefanha-thinkpad.muc.redhat.com \
--to=stefanha@gmail.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).