From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40540)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VnqxL-0002UM-70
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 09:28:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VnqxF-00019j-RO
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 09:28:07 -0500
Received: from nodalink.pck.nerim.net ([62.212.105.220]:43119
	helo=paradis.irqsave.net) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1VnqxF-00019B-G5
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 09:28:01 -0500
Date: Tue, 3 Dec 2013 15:27:53 +0100
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20131203142753.GB19702@irqsave.net>
References: <1386059127-30962-1-git-send-email-famz@redhat.com>
	<1386059127-30962-3-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1386059127-30962-3-git-send-email-famz@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 2/6] qemu-iotests: Honour cache mode in
 iotests.py
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, WenchaoXia <xiawenc@linux.vnet.ibm.com>

Le Tuesday 03 Dec 2013 =E0 16:25:23 (+0800), Fam Zheng a =E9crit :
> This will allow overriding cache mode from the "-c mode" option.
>=20
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/qemu-iotests/iotests.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests=
.py
> index fb10ff4..c84a1a5 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -37,6 +37,7 @@ qemu_args =3D os.environ.get('QEMU', 'qemu').strip().=
split(' ')
>  imgfmt =3D os.environ.get('IMGFMT', 'raw')
>  imgproto =3D os.environ.get('IMGPROTO', 'file')
>  test_dir =3D os.environ.get('TEST_DIR', '/var/tmp')
> +cachemode =3D os.environ.get('CACHEMODE')
+cachemode =3D os.environ.get('CACHEMODE', "none")

This way the default would be preserved.

> =20
>  socket_scm_helper =3D os.environ.get('SOCKET_SCM_HELPER', 'socket_scm_=
helper')
> =20
> @@ -96,7 +97,7 @@ class VM(object):
>          '''Add a virtio-blk drive to the VM'''
>          options =3D ['if=3Dvirtio',
>                     'format=3D%s' % imgfmt,
> -                   'cache=3Dnone',
> +                   'cache=3D%s' % cachemode,
>                     'file=3D%s' % path,
>                     'id=3Ddrive%d' % self._num_drives]
>          if opts:
> --=20
> 1.8.4.2
>=20
>=20