From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54037)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VnrlF-0004bf-GQ
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 10:19:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1VnrlA-0001zl-35
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 10:19:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59910)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Vnrl9-0001zX-Ro
	for qemu-devel@nongnu.org; Tue, 03 Dec 2013 10:19:36 -0500
Date: Tue, 3 Dec 2013 16:19:26 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20131203151926.GG9956@dhcp-200-207.str.redhat.com>
References: <1386059127-30962-1-git-send-email-famz@redhat.com>
	<1386059127-30962-3-git-send-email-famz@redhat.com>
	<20131203142753.GB19702@irqsave.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20131203142753.GB19702@irqsave.net>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 2/6] qemu-iotests: Honour cache mode in
 iotests.py
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com, WenchaoXia <xiawenc@linux.vnet.ibm.com>

Am 03.12.2013 um 15:27 hat Beno=EEt Canet geschrieben:
> Le Tuesday 03 Dec 2013 =E0 16:25:23 (+0800), Fam Zheng a =E9crit :
> > This will allow overriding cache mode from the "-c mode" option.
> >=20
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  tests/qemu-iotests/iotests.py | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotes=
ts.py
> > index fb10ff4..c84a1a5 100644
> > --- a/tests/qemu-iotests/iotests.py
> > +++ b/tests/qemu-iotests/iotests.py
> > @@ -37,6 +37,7 @@ qemu_args =3D os.environ.get('QEMU', 'qemu').strip(=
).split(' ')
> >  imgfmt =3D os.environ.get('IMGFMT', 'raw')
> >  imgproto =3D os.environ.get('IMGPROTO', 'file')
> >  test_dir =3D os.environ.get('TEST_DIR', '/var/tmp')
> > +cachemode =3D os.environ.get('CACHEMODE')
> +cachemode =3D os.environ.get('CACHEMODE', "none")
>=20
> This way the default would be preserved.

CACHEMODE is always set, so you'd never get the default anyway. If
anything, it would have to use that other environment variable that
tells us if we're running the default. It's probably not necessary,
though.

Kevin